Repository navigation
Modernize the dev toolchain on Bun; clear the 50 Dependabot alerts - #33
Merged
Merged
Conversation
- bun.lock replaces package-lock.json (and the 50 dev-only Dependabot alerts pinned in it: webpack-dev-server, vite/vitest, undici, ...) - Tests run on bun:test with happy-dom instead of vitest + jsdom; the suite is unchanged apart from the vi.* helpers and one act() wrap - The demo runs on Bun's built-in HTML dev server (bun run dev, port 3456); Bun renders the README import to HTML, so react-markdown goes - Sources move to src/, the demo to examples/SmoothieDemo.tsx - TypeScript 7; rootDir and strict pinned so dist/ is byte-identical to the published 1.0.0 - build stays runner-agnostic so git installs via npm still work Consumer contract unchanged: same exports, types, peer range (react >=16.8) and smoothie dependency. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Git stores LF (* text=auto); editors and Prettier use the checkout's native endings instead of forcing LF. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- ci.yml: typecheck, Prettier, tests and build on Ubuntu + Windows with React 19, plus a React 18 leg; a package job packs the tarball (via prepare, like a git install) and loads it with require() and import() - npm.yml now only runs on v* tags: test with Bun, then npm publish --provenance via Trusted Publishing, then the GitHub Release. The file name stays because the npm trusted-publisher entry names it - dependabot.yml: weekly grouped bun + github-actions updates Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
- Install with bun or npm; spell out the react peer dependency - Replace the React.createClass/string-ref examples with a function component and a class with createRef - Note that chart options are read at mount (#14) and how to rebuild - Development section for the Bun toolchain; Unreleased changelog entry Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This was referenced Nov 7, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clears the repo's 50 open Dependabot alerts by moving the dev toolchain to Bun. The published package doesn't change:
dist/built on this branch is byte-identical to the publishedreact-smoothie@1.0.0, so no release is needed for this.What changed
bun.lockreplacespackage-lock.json, which is where every open alert lived (webpack-dev-server, vite/vitest, undici via jsdom, fast-uri, launch-editor, proxy-addr, …). That drops webpack, webpack-cli, webpack-dev-server, ts-loader, html-webpack-plugin, nodemon, ts-node, vitest, jsdom and react-markdown. 60 packages remain, andbun auditreports no vulnerabilities.bun:testwith happy-dom (preload insrc/test-setup.ts). All 14 tests pass. The only changes are swapping out thevi.*helpers and wrapping onemousemoveinact().bun run devservesexamples/index.htmlon Bun's built-in dev server (port 3456). Bun's bundler renders the README import to HTML, so react-markdown is gone.src/.example.tsxmoves toexamples/SmoothieDemo.tsx.rootDir: "src"andstrict: falseare pinned because TS 6+ changed both defaults. That keeps the output paths and the.d.tsshape identical to 1.0.0.ci.yml): typecheck, Prettier, tests and build on Ubuntu and Windows with React 19, plus a React 18 leg. A package job runsnpm pack, which builds throughpreparethe same way a git install does, then installs the tarball into a bare consumer and checks that bothrequire()andimport()load under Node 24.npm.yml): now runs only onv*tags. It tests with Bun, publishes withnpm publish --provenancevia Trusted Publishing (nextdist-tag for prereleases, as before), then creates the GitHub Release.dependabot.yml: weekly groupedbunandgithub-actionsupdates, ignoring@types/nodemajors..gitattributes(* text=auto); PrettierendOfLine: auto. Removed.npmrc(engine-strictwith noenginesfield did nothing).React.createClass, a note that chart options are read only at mount (Additional properties #14), a Development section and an Unreleased changelog entry.Consumer-facing changes
None to the runtime API, exports, types,
exportsmap, peer range or dependencies. The only tarball difference is the demo's path:example.tsxbecomesexamples/SmoothieDemo.tsx.Choices made (the plan was stale)
plans/react-smoothie.mdwas written in May, before the 0.14.0 and 1.0.0 releases you made by hand in July. Where it conflicted with what's already published, I kept the published 1.0.0 contract:dependency(^1.36.1), not the peer dependency the plan proposed. Moving it would break consumers who don't install smoothie themselves.>=16.8, not the plan's^17 || ^18 || ^19.jsx: react) stays, notreact-jsx(plan open question 2).react/jsx-runtimedoesn't exist in React 16.8–16.13, which the peer range allows.example.tsx, moved it toexamples/SmoothieDemo.tsx, and still ship it (plan open question 4). The README links to it.npm.yml, not the plan'spublish.yml. The Trusted Publisher entry on npm names the workflow file, so renaming it would break publishing until npm is reconfigured. That also settles open question 1: Trusted Publishing is already live.preparesonpm i cinderblock/react-smoothiegit installs still build.builduses onlynodeandtsc, so it works under both npm and bun.How I verified it
bun run typecheck,bun run format:check,bun test(14/14) andbun run buildpass on Windows.bun testalso passes with React 18.3.1.diff -rofdist/frombun run buildand fromnpm packagainst the publishedreact-smoothie@1.0.0tarball: identical.require('react-smoothie')andimport('react-smoothie')both load under Node with the same six exports.bun run dev, loaded in headless Chromium: all 10 canvases draw, the README renders, no console errors.bun audit: no vulnerabilities.What's left
package-lock.jsonalerts should close as fixed, since that manifest is gone.v2branch (uPlot rewrite) has its ownbun.lockand annpm.ymlthat still runs CI. Expect conflicts in.github/workflows/npm.ymlandREADME.mdwhenever v2 meets master.strict(that changes the emitted.d.ts, so do it with care), and test React 16.8/17 (needs an older Testing Library).Supersedes
#15, #17, #19, #20, #21, #22, #23, #24, #25, #26, #27, #28, #29. All are transitive bumps in the removed
package-lock.json, apart from #26 (smoothie 1.35 → 1.36.1), which master already has:^1.36.1, and this lock resolves 1.36.1.🤖 Generated with Claude Code