Skip to content

fix: dedupe repeated inline rows in list output#11

Merged
dylandreimerink merged 1 commit into
cilium:mainfrom
immanuwell:fix/dedupe-inline-display
Jul 14, 2026
Merged

fix: dedupe repeated inline rows in list output#11
dylandreimerink merged 1 commit into
cilium:mainfrom
immanuwell:fix/dedupe-inline-display

Conversation

@immanuwell

Copy link
Copy Markdown
Contributor

list <obj> <prog> can print the same row twice when an inline helper gets reused at different call sites. In plain text those rows look identical, so its just noise.

Repro on main

  1. go run ./cmd/stackwhere list ./testdata/basic.o cil_entry
  2. At R10-32: you get two_inlined_a twice and two_inlined_b twice

Fix

  • dedupe display-identical rows in plain text output
  • keep JSON and --call-stack untouched, so the full call-site detail still shows up there

Checks

  • go test ./...

Signed-off-by: immanuwell <pchpr.00@list.ru>
@immanuwell

Copy link
Copy Markdown
Contributor Author

@dylandreimerink WDYT?

@dylandreimerink

Copy link
Copy Markdown
Member

Nice, thank you!

@dylandreimerink
dylandreimerink merged commit 75411c0 into cilium:main Jul 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants