Modernise repository - #13
Merged
Merged
Conversation
Build:
- gradle.properties: add cics.bom.version property; improve comments
- build.gradle: use cics.bom.version property; fix archivesBaseName ->
war { archiveFileName }; add bootWar { enabled = false }; add wtp
block to pin jst.web 6.0 and contextPath (Issue 13); move java block
before eclipse block; use CICS bracket style throughout
- settings.gradle: fix plugins block to CICS bracket style
- Maven wrapper: upgrade from 3.8.5 to 3.9.12 (only-script type);
remove MavenWrapperDownloader.java and maven-wrapper.jar
- root pom.xml: add cics.bom.version property; move maven-compiler-plugin
here so release flag is set once for all child modules; remove
duplicate dependencyManagement BOM import from root; fix
xsi:schemaLocation to https://
- app pom.xml: reference ${cics.bom.version}; add <finalName>; remove
redundant java.version / compiler plugin (now in root); add
spring-boot.repackage.skip; fix xsi:schemaLocation to https://
- cicsbundle pom.xml: fix xsi:schemaLocation to https://
Eclipse:
- Remove WTP facet files from root .settings/ (Issue 10)
- Add org.eclipse.core.resources.prefs and org.eclipse.jdt.core.prefs
to root and -app .settings/ with Java 17 compiler settings (Issue 7)
- Update both .classpath files: JRE container JavaSE-1.8 -> JavaSE-17
- root .classpath: reduce to minimal parent container form
- app .classpath: add CICS Liberty Libraries (V61/JEE_V10_R0), Gradle
and Maven classpath containers
- Add org.eclipse.wst.validation.prefs to -app to suppress duplicate
JAR errors after Maven Update Project (Issue 11a)
web.xml:
- Upgrade from Servlet 3.1 (javax) to Servlet 6.0 (jakarta namespace)
- Rename security role from ROLE_USER to cicsAllAuthenticated
CI:
- Rename java.yaml -> build.yaml
- Replace outdated 3-job matrix (JDK 8/11/17 experimental) with
standard 4-way matrix: build-maven, build-mvnw, build-gradle,
build-gradlew all on JDK [17, 21, 25]
- Use verify (not package) for Maven; clean build for Gradle
- Add copyright checker job with correct permissions
- Use modern actions: checkout@v4, setup-java@v4, setup-gradle@v4
with gradle-version: 8.14.4
- Remove artifact upload steps
- Add top-level permissions: contents: read
Docs:
- Replace MAINTAINERS.md with CODEOWNERS referencing
@cicsdev/cics-java-maintainers
- README.md: full rewrite — correct build badge (cicsdev/build.yaml), add licence badge (EPL 2.0 green), update prerequisites to CICS V6.1 and Java 17, fix build commands (clean build / clean verify), update BOM snippet to current version, fix servlet feature to servlet-6.0, rename ROLE_USER -> cicsAllAuthenticated throughout, fix app id/location in server.xml snippet to use repo name (not versioned), add standard sections (Overview, ToC, Contributing, Additional Resources, Running the Sample), add three standard deployment sections - ibm-web-ext.xml: add to WEB-INF/ with context-root cics-java-liberty-springboot-security (required for consistent URL across all deployment methods) - wst.common.component: fix deploy-name from Java package style to repo name (cics-java-liberty-springboot-security) - cicsbundle-eclipse: add standalone Eclipse CICS bundle project with .project, META-INF/cics.xml, and .warbundle referencing -app - etc/config/liberty/server.xml: add sample server config with servlet-6.0 and cicsts:security-1.0 - cleanup-old-runs.yaml: add workflow to purge old CI runs weekly
IvanHargreaves
requested changes
Jul 29, 2026
IvanHargreaves
left a comment
IvanHargreaves
left a comment
Contributor
There was a problem hiding this comment.
Just one minor change suggested, the rest looks great.
|
|
||
| on: | ||
| push: | ||
| branches: ["manvi/samples"] |
Contributor
There was a problem hiding this comment.
This has your branch name in, which won't work at main.
Contributor
Author
There was a problem hiding this comment.
yeah right,missed that
IvanHargreaves
approved these changes
Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.