Repository navigation
C# flags: keep the underlying type in the bitwise operators and Remov… - #112
Closed
jccarvalhosa wants to merge 2 commits into
Closed
jccarvalhosa wants to merge 2 commits into
jccarvalhosa wants to merge 2 commits into
Conversation
…eFlags The C# flags template cast the result of &, |, ^ and the complement in RemoveFlags to byte, whatever the declared base type. For a flags type on int32 (the default) or any type wider than a byte, combining two values above 0xFF lost them (0x400 | 0x1000 gave 0) and RemoveFlags cleared every flag from 0x100 up. The casts now use _FLAGS_TYPE_, as the constructor and the deserializer already do; byte-based flags generate the same code as before. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
chronoxor
added a commit
that referenced
this pull request
Oct 13, 2026
Owner
|
Fixed! Thanks for reporting! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…eFlags
The C# flags template cast the result of &, |, ^ and the complement in RemoveFlags to byte, whatever the declared base type. For a flags type on int32 (the default) or any type wider than a byte, combining two values above 0xFF lost them (0x400 | 0x1000 gave 0) and RemoveFlags cleared every flag from 0x100 up. The casts now use FLAGS_TYPE, as the constructor and the deserializer already do; byte-based flags generate the same code as before.