Rebase concrete exceptions onto Mcp\Exception base classes - #39
Open
chr-hertel wants to merge 2 commits into
Open
Rebase concrete exceptions onto Mcp\Exception base classes#39chr-hertel wants to merge 2 commits into
chr-hertel wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All concrete SDK exceptions that extended the global
\RuntimeException/\InvalidArgumentException/\Exceptiondirectly now extend the correspondingMcp\Exception\*base class, socatch (\Mcp\Exception\RuntimeException)and friends actually catch them.Mcp\Exception\RuntimeExceptionlosesfinalto serve as a parent.BC-safe: the Mcp bases extend the same global classes, so every existing
catchandinstanceof(including the\InvalidArgumentExceptionecho branches inProtocolandStatelessProtocol) keeps matching identically.Adds
ExceptionHierarchyTestasserting every exception insrc/Exceptionis catchable through an Mcp base class.MessageFactory::createMessage()now re-throwsInvalidInputMessageExceptionunchanged instead of re-wrapping it (its catch on Mcp'sInvalidArgumentExceptionwould otherwise match it after this rehoming, erasing subtypes), with a regression test.Follow-up idea (not implemented here): the "safe to echo to the client" decision in both protocols still keys off
\InvalidArgumentException; an explicit opt-in marker interface (e.g.ClientVisibleMessageInterface) implemented byMcp\Exception\InvalidArgumentExceptionwould make that contract explicit with identical behavior.Closes #20
Confidence: 9/10 — mechanical parent-class swap with unchanged catch/instanceof semantics, full unit suite, php-cs-fixer and phpstan green; small residual risk only from downstream code relying on exact-class checks.