fix(preflight): preview the file name with the day Which day will write

[chhoumann]

Summary

Three things for the 2.24.0 release:

1. Fix: the one-page form's File name preview rendered {{DATE}} with today's clock even when the choice's Which day setting, or the date picked in the form's own date field, aimed the run at another day. Picking August 27 showed Daily/2026-09-01 and then wrote Daily/2026-08-27. The preview now resolves the run clocks the same way ChoiceExecutor.applyDateOrigin does (setting → executor clocks → form seed) and hands them to the preview formatter.
2. Docs assets: screenshots and GIFs for the 2.24.0 release notes under docs/public/img/release-2.24.0/, per the convention in docs/README.md (referenced from the release body via SHA-pinned raw URLs; the folder can be pruned from HEAD afterwards).
3. Docs typo: the "Paste images straight into the prompt" note in FormatSyntax.md had its first sentence duplicated.

Changes

• FileNameDisplayFormatter.setRunClocks() – a seam for the preview to receive the run's calendar origin.
• runOnePagePreflight.ts – previewRunClocks() mirrors applyDateOrigin (relative presets, ask seeded from __qa.dateOrigin, executor-inherited clocks) and feeds the formatter before computing the preview.
• Four regression tests in runOnePagePreflight.filenamePreview.test.ts (relative day, typed day, empty field falls back to today, executor-inherited day). Three of them fail without the fix.
• docs/public/img/release-2.24.0/ – 8 assets (2.3 MB).
• docs/src/content/docs/docs/FormatSyntax.md – one duplicated line removed.

Testing / validation

• pnpm run build-with-lint passes; pnpm run test: 421 files, 5200 tests passing.
• Verified live in Obsidian 1.13.7 (isolated e2e vault): running Daily note (pick a day) and picking Aug 27 now shows File name: Daily/2026-08-27 in the form (was Daily/2026-09-01), and the created note is Daily/2026-08-27.md.

Checklist

• PR title follows Conventional Commits
  — it becomes the squash-merge commit and drives the released version.
• Linked any related issue(s). Relates to [FEATURE REQUEST] Prompt for a date as the {{DATE}} origin #1708 (Which day / date origin).
• Noted release/migration impact, if any. None; this lands in 2.24.0 alongside the feature it previews.

  

Summary by CodeRabbit

• Bug Fixes

  • File-name previews now display the correct date based on the selected date setting.
  • Previews correctly handle relative dates, manually entered dates, empty date fields, and dates resolved during execution.

• Documentation

  • Added a titled note explaining how to paste images directly into prompts.

• Tests

  • Added coverage for date-based file-name preview scenarios.

[chatgpt-codex-connector]

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-09-01T22:18:31.812100Z	3b7c0d2	PR opened

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

• Open a pull request for review
• Mark a draft as ready
• Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: b3c1c9a4-5f68-4556-a664-0d116edef3c5

📥 Commits

Reviewing files that changed from the base of the PR and between 3b7c0d2 and 3409686.

📒 Files selected for processing (1)

• docs/src/content/docs/docs/FormatSyntax.md

💤 Files with no reviewable changes (1)

• docs/src/content/docs/docs/FormatSyntax.md

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.

---

📝 Walkthrough

Walkthrough

The one-page filename preview now resolves date-origin settings before formatting. FileNameDisplayFormatter receives the planned run clocks, and tests cover relative, entered, fallback, and executor-resolved dates. The format syntax documentation adds a titled note for image prompts.

Changes

Date-aware filename preview

Layer / File(s)	Summary
Formatter run-clock contract src/formatters/fileNameDisplayFormatter.ts	FileNameDisplayFormatter now exposes setRunClocks to update the clocks used by date previews.
Preflight date resolution and validation src/preflight/runOnePagePreflight.ts, src/preflight/runOnePagePreflight.filenamePreview.test.ts	Preflight resolves clocks with planDateOrigin, applies them before rendering, and tests relative, entered, fallback, and executor-resolved dates.

Format syntax documentation

Layer / File(s)	Summary
Image prompt documentation docs/src/content/docs/docs/FormatSyntax.md	The image prompt guidance now appears in a titled note callout.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 34096

This PR makes the file-name preview use the selected run day and includes documentation assets and a typo fix; no actionable merge-blocking risk remains after normal checks and review.

Sequence Diagram(s)

sequenceDiagram
  participant OnePagePreflight
  participant previewRunClocks
  participant planDateOrigin
  participant FileNameDisplayFormatter
  OnePagePreflight->>previewRunClocks: choice, executor clocks, and form values
  previewRunClocks->>planDateOrigin: date origin, variables, form values, and seed
  planDateOrigin-->>previewRunClocks: planned run clocks
  previewRunClocks-->>OnePagePreflight: preview run clocks
  OnePagePreflight->>FileNameDisplayFormatter: setRunClocks
  OnePagePreflight->>FileNameDisplayFormatter: format filename preview

Loading

Poem

A rabbit checks the date,
Run clocks guide the preview path,
Forms supply the day,
Tests watch each origin choice,
Notes mark prompts with care.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 50.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 3 files.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately identifies the preflight file-name preview change and the date selected by the Which day setting. Although the wording is grammatically awkward, it is specific and related to the …
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

Full details: Title check

Explanation

The title accurately identifies the preflight file-name preview change and the date selected by the Which day setting. Although the wording is grammatically awkward, it is specific and related to the main change.

• Fix all pre-merge checks with AI

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch cursor/release-2-24-0-notes-7ecf

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[cloudflare-workers-and-pages]

Deploying quickadd with    Cloudflare Pages

Latest commit:	3409686
Status:	✅  Deploy successful!
Preview URL:	https://d3ba011c.quickadd.pages.dev
Branch Preview URL:	https://cursor-release-2-24-0-notes.quickadd.pages.dev

View logs