feat(preflight): add wiki-link autocomplete and peek to one-page inputs - #1715
feat(preflight): add wiki-link autocomplete and peek to one-page inputs#1715chhoumann wants to merge 2 commits into
Conversation
One-page text and textarea fields now complete [[ and # the same way sequential prompts do. Peek at note hides the whole form and inserts an editor selection into the last focused free-text field. Closes #1702 Co-authored-by: Christian Bager Bach Houmann <christian@bagerbach.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (6)
Included review availability: Your plan provides up to 8 included reviews per hour; 5 remain after this review. 📝 WalkthroughWalkthroughChangesOne-page input features
Estimated code review effort: 3 (Moderate) | ~25 minutes Merge Risk: 🔵 Low · up to One-page forms can now place explicitly selected editor content into values returned to API callers. This is bounded by deliberate user actions, but caller trust and consent expectations should be documented; the change is otherwise mergeable with owner awareness. Sequence Diagram(s)sequenceDiagram
participant User
participant OnePageInputModal
participant InputPromptPeek
participant ObsidianEditor
User->>OnePageInputModal: Select Peek at note or press shortcut
OnePageInputModal->>InputPromptPeek: Open peek session
InputPromptPeek->>ObsidianEditor: Read or select note text
User->>InputPromptPeek: Insert selection
InputPromptPeek->>OnePageInputModal: Restore modal and insert text
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Linked Issues checkExplanation The pull request satisfies issue
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying quickadd with
|
| Latest commit: |
84c9b99
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://e209e273.quickadd.pages.dev |
| Branch Preview URL: | https://cursor-one-page-link-peek-06.quickadd.pages.dev |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 54acc22f68
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
End-to-end review: changes neededReviewed head
Build, lint, Svelte checks, focused tests, coverage, and hosted checks passed. The isolated Obsidian suite passed 49/50; the sole date-case timeout is unchanged from the base. I would not merge until the three P2 findings are addressed. |
…x a11y Tag completion treated any earlier [[ as inside a wiki-link, so See [[Note]] then #tag never opened. The shared TextInputSuggest now exposes a real combobox, and one-page forms refresh the tag index once instead of once per free-text field. Co-authored-by: Christian Bager Bach Houmann <christian@bagerbach.com>
2 participants
Why
Issue #1702 asks the one-page form to match sequential text prompts for two things:
[[/#autocomplete, and Peek at note. Both were documented as missing. This ports the existingFileSuggester,TagSuggester, andInputPromptPeekontoOnePageInputModalinstead of adding a second peek stack.Scope
OnePageInputModalattaches file and tag suggesters totext,textarea, and the unknown-type fallback. Number, slider, date, dropdown, field-suggest, suggester, and file-picker widgets stay on their own controls.runOnePagePreflight,quickAddApi.requestInputs) are unchanged.ControllingPrompts.md,SuggesterSystem.md, andonePageInputs.mdnow describe the form as having these features.Review follow-up (
84c9b990)Addresses the three P2s from the end-to-end review:
TagSuggesternow ignores#only inside an unclosed[[.TextInputSuggest:role=combobox, stablearia-controls,aria-activedescendanton keyboard selection. One-page free-text fields getaria-labelledbyfrom the field label.TagSuggesterrebuilds the shared index.Tradeoffs
Blast Radius
Users of one-page input get
[[/#in free-text fields and a Peek button on every form, includingrequestInputs. Settings and builder prompts are untouched. No migration. No settings change.Verification
tagSuggester,suggest,OnePageInputModal.linkSuggesters).pnpm run testpassed (5102 tests, 37 skipped).pnpm run build-with-lintpassed.quickadd-demo-vault: one-page form file suggestions after[[, tag suggestions after a closed[[Target Note]], Peek hide + insert selection intobody.one_page_wikilink_tag_peek_demo.mp4
Wiki-link file suggestions after typing [[
Tag suggestions after a closed wiki-link
Peek waiting with insert-selection chip
Form after wiki-link, tag, and peek insert
Checklist
Closes #1702
To show artifacts inline, enable in settings.
Summary by CodeRabbit
New Features
[[) and tag (#) suggestions to text and textarea fields in one-page forms.Bug Fixes
Documentation