Repository navigation
Fix escaped URI cache keys when ignoring query order - #46
Open
bensynapse wants to merge 1 commit into
Open
bensynapse wants to merge 1 commit into
bensynapse wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I run Live Tennis API.
With
IgnoreQueryOrder(),/cache?x=a%26y%3Dband/cache?x=a&y=bcurrently share a response cache entry. The second request receives the first response.Encode the sorted query values and retain the escaped path. Invalid query escapes use the existing raw URI fallback. Reordered parameters and repeated values still share a cache entry.
The regressions cover both
IgnoreQueryOrder()andCacheStrategyRequestURIIgnoreQueryOrder. Twenty-one regression cases fail against the original code.go test -race -coverprofile=coverage.xml -v ./...andgo build -v ./...pass on Go 1.13.15 and 1.23.4.go vet ./...and golangci-lint 1.54.2 also pass.