Fix brpc_proto_library failure when brpc is used as an external Bazel dependency - #61
Closed
chenBright wants to merge 1 commit into
Closed
Fix brpc_proto_library failure when brpc is used as an external Bazel dependency#61chenBright wants to merge 1 commit into
chenBright wants to merge 1 commit into
Conversation
chenBright
force-pushed
the
fix_proto_gen
branch
5 times, most recently
from
August 5, 2026 11:17
7811be7 to
4bf43e2
Compare
chenBright
force-pushed
the
fix_proto_gen
branch
from
August 5, 2026 11:21
4bf43e2 to
f317b7c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number:
Problem Summary:
When bRPC is built as an external Bazel dependency,
brpc_proto_librarypasses"."to theincludesattribute ofcc_library. In the root package of the external repository,"."resolves to the workspace root, causing Bazel to reject the target because it would expose every file in the workspace to the rule and all its transitive dependents:What is changed and the side effects?
Changed:
Side effects:
Performance effects:
Breaking backward compatibility:
Check List: