Skip to content

fix: sync core - #4412

Merged
tpoisseau merged 8 commits into
mainfrom
enable-eslint-rules
Oct 16, 2026
Merged

tpoisseau merged 8 commits into
mainfrom
enable-eslint-rules

Conversation

@tpoisseau

Copy link
Copy Markdown
Contributor

add force to supported prefixes

Refs: https://github.com/zakodium/nmrium/issues/1000

@tpoisseau
tpoisseau marked this pull request as draft October 15, 2026 10:16
@targos

targos commented Oct 15, 2026

Copy link
Copy Markdown
Member

You don't have to do it in this PR but you can also enable it in this project:

'unicorn/consistent-boolean-name': 'off',

tpoisseau added a commit that referenced this pull request Oct 15, 2026
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 15, 2026 •

Copy link
Copy Markdown

Deploying nmrium with  Cloudflare Pages  Cloudflare Pages

Latest commit: af2136f
Status: ✅  Deploy successful!
Preview URL: https://b0d744d4.nmrium.pages.dev
Branch Preview URL: https://enable-eslint-rules.nmrium.pages.dev

View logs

@targos

targos commented Oct 15, 2026

Copy link
Copy Markdown
Member

Configuration for rule "unicorn/consistent-boolean-name" is invalid. Expected severity of "off", 0, "warn", 1, "error", or 2.

You passed '"on"'.

@tpoisseau
tpoisseau force-pushed the enable-eslint-rules branch from 7e77851 to 7b685ef Compare October 15, 2026 13:46
transient deps update method
1. `package.json#resolutions['eslint-config-cheminfo'] = '19.4.0'`
2. `yarn && yarn dedupe`
3. `delete package.json#resolutions['eslint-config-cheminfo']`

Refs: https://github.com/cheminfo/eslint-config/releases/tag/v19.4.0
Refs: zakodium/nmrium#1016 (comment)
# Conflicts:
#	package-lock.json
#	package.json
@tpoisseau
tpoisseau marked this pull request as ready for review October 16, 2026 09:21
@tpoisseau
tpoisseau requested a review from targos October 16, 2026 09:21
@tpoisseau tpoisseau changed the title fix: enable unicorn/consistent-boolean-name rule fix: sync core Oct 16, 2026
@tpoisseau
tpoisseau enabled auto-merge (squash) October 16, 2026 09:25
@tpoisseau
tpoisseau merged commit 3deea33 into main Oct 16, 2026
12 checks passed
@tpoisseau
tpoisseau deleted the enable-eslint-rules branch October 16, 2026 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants