Skip to content

feature/INT-1663 - Support for negotiating Accounts API schema version via the Accept header - #188

Merged
david-ruiz-cko merged 3 commits into
masterfrom
feature/INT-1663
Jul 30, 2026
Merged

feature/INT-1663 - Support for negotiating Accounts API schema version via the Accept header#188
david-ruiz-cko merged 3 commits into
masterfrom
feature/INT-1663

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This pull request adds support for Accounts API v3.0 onboarding and extends the SDK to handle new business requirements. The main changes include introducing new models and enumerations for onboarding, updating existing models with new attributes, and enhancing the AccountsClient to support versioned Accept headers for API requests.

Accounts API v3.0 onboarding support:

  • Added new models and enums for onboarding, including AgreedTerms, ProcessingDetailsAch, ProcessingDetailsPayments, CompanyPosition, EntityRoles, NationalIdType, Citizenship, RepresentativeIndividual, FinancialStatements, FinancialStatementsType, and ArticlesOfAssociation. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

  • AccountsClient methods (create_entity, get_entity, update_entity, get_entity_requirements) now accept an optional schema_version parameter (defaulting to '3.0') and send a versioned Accept header, enabling API version negotiation. [1] [2] [3] [4]

Model enhancements and new attributes:

  • Company now supports additional_trading_names (array of strings) and is_registered_company (boolean). [1] [2]
  • DateOfIncorporation adds a day attribute.
  • Phone adds a country_code attribute.
  • OnboardEntity and Representative models are extended with new attributes for v3.0 (e.g., agreed_terms, individual, company_position, ownership_percentage). [1] [2] [3] [4]
  • OnboardSubEntityDocuments now supports financial_statements and uses the new ArticlesOfAssociation type. [1] [2] [3]
  • ProcessingDetails adds average_order_fulfillment_time and a nested payments attribute.

Enumerations and types:

  • BusinessType expanded with several new business entity types to cover more onboarding scenarios.

These changes collectively enable the SDK to support the latest onboarding requirements and improve flexibility for future API versions.

@david-ruiz-cko
david-ruiz-cko requested a review from a team July 30, 2026 10:56
@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:637>200

Operational gates

  • ✅ jira_ticket (INT-1663)
  • ✅ independent_review

Files analysed: 26


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope637>200 classifying §2.1 M8 More than 200 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:641>200

Operational gates

  • ✅ jira_ticket (INT-1663)
  • ✅ independent_review

Files analysed: 26


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope641>200 classifying §2.1 M8 More than 200 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • exceeds_bounded_scope:648>200

Operational gates

  • ✅ jira_ticket (INT-1663)
  • ✅ independent_review

Files analysed: 26


wall-e 2026.06.19-02 · policy 376219bc71e6…

@agent-wall-e

agent-wall-e Bot commented Jul 30, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
exceeds_bounded_scope648>200 classifying §2.1 M8 More than 200 non-test, non-doc, non-lockfile lines changed.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@sonarqubecloud

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit d76fded into master Jul 30, 2026
5 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the feature/INT-1663 branch July 30, 2026 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants