Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/checkout_sdk/forward/create_secret_request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module CheckoutSdk
module Forward
# Request body for POST /forward/secrets.
# Request body for POST /secrets.
#
# @!attribute name
# @return [String] Secret name (1-64 alphanumeric chars).
Expand Down
8 changes: 4 additions & 4 deletions lib/checkout_sdk/forward/forward_client.rb
Original file line number Diff line number Diff line change
Expand Up @@ -25,26 +25,26 @@ def get(forward_id)

# @param [Hash, CreateSecretRequest] create_secret_request
def create_secret(create_secret_request)
api_client.invoke_post(build_path(FORWARD, SECRETS),
api_client.invoke_post(build_path(SECRETS),
sdk_authorization,
create_secret_request)
end

def get_secrets
api_client.invoke_get(build_path(FORWARD, SECRETS), sdk_authorization)
api_client.invoke_get(build_path(SECRETS), sdk_authorization)
end

# @param [String] name
# @param [Hash, UpdateSecretRequest] update_secret_request
def update_secret(name, update_secret_request)
api_client.invoke_patch(build_path(FORWARD, SECRETS, name),
api_client.invoke_patch(build_path(SECRETS, name),
sdk_authorization,
update_secret_request)
end

# @param [String] name
def delete_secret(name)
api_client.invoke_delete(build_path(FORWARD, SECRETS, name),
api_client.invoke_delete(build_path(SECRETS, name),
sdk_authorization)
end
end
Expand Down
2 changes: 1 addition & 1 deletion lib/checkout_sdk/forward/update_secret_request.rb
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

module CheckoutSdk
module Forward
# Request body for PATCH /forward/secrets/{name}.
# Request body for PATCH /secrets/{name}.
#
# @!attribute value
# @return [String] New plaintext secret value (max 8KB).
Expand Down
18 changes: 9 additions & 9 deletions spec/checkout_sdk/forward/forward_secrets_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,44 +10,44 @@
end

describe '#create_secret' do
it 'POSTs typed DTO to forward/secrets' do
it 'POSTs typed DTO to secrets' do
req = CheckoutSdk::Forward::CreateSecretRequest.new
req.name = 'sk_test'
req.value = 'secret'
expect(api_client_mock).to receive(:invoke_post)
.with('forward/secrets', 'secret_key', req).and_return('r')
.with('secrets', 'secret_key', req).and_return('r')
expect(client.create_secret(req)).to eq('r')
end

it 'also accepts a raw Hash' do
h = { 'name' => 's', 'value' => 'v' }
expect(api_client_mock).to receive(:invoke_post)
.with('forward/secrets', 'secret_key', h).and_return('r')
.with('secrets', 'secret_key', h).and_return('r')
expect(client.create_secret(h)).to eq('r')
end
end

describe '#get_secrets' do
it 'GETs forward/secrets' do
it 'GETs secrets' do
expect(api_client_mock).to receive(:invoke_get)
.with('forward/secrets', 'secret_key').and_return('r')
.with('secrets', 'secret_key').and_return('r')
expect(client.get_secrets).to eq('r')
end
end

describe '#update_secret' do
it 'PATCHes typed DTO to forward/secrets/{name}' do
it 'PATCHes typed DTO to secrets/{name}' do
req = CheckoutSdk::Forward::UpdateSecretRequest.new
expect(api_client_mock).to receive(:invoke_patch)
.with('forward/secrets/my_name', 'secret_key', req).and_return('r')
.with('secrets/my_name', 'secret_key', req).and_return('r')
expect(client.update_secret('my_name', req)).to eq('r')
end
end

describe '#delete_secret' do
it 'DELETEs forward/secrets/{name}' do
it 'DELETEs secrets/{name}' do
expect(api_client_mock).to receive(:invoke_delete)
.with('forward/secrets/my_name', 'secret_key').and_return('r')
.with('secrets/my_name', 'secret_key').and_return('r')
expect(client.delete_secret('my_name')).to eq('r')
end
end
Expand Down
Loading