Skip to content

Release 4.6.0 - Representative documents alignment - #249

Merged
david-ruiz-cko merged 1 commit into
mainfrom
release/4.6.0
Oct 6, 2026
Merged

david-ruiz-cko merged 1 commit into
mainfrom
release/4.6.0

Conversation

@david-ruiz-cko

Copy link
Copy Markdown
Contributor

This release significantly expands and updates the integration and serialization tests for account onboarding entities, with a focus on schema 3.0 and representative document handling. It introduces new test cases for uploading and linking representative documents, adds utility methods for building valid company requests, and improves coverage for EEA Sole Trader scenarios. The changes ensure the SDK's test suite accurately reflects the latest API requirements and behaviors.

Integration test enhancements:

  • Added new tests to verify onboarding of entities with representative documents, including identity verification and certified authorised signatory, and ensured that documents are echoed back by the API (test_should_onboard_entity_with_representative_documents).
  • Added tests for uploading EEA Sole Trader proof files and retrieving them, covering the required purposes (test_should_upload_representative_proof_files).
  • Updated the file upload and retrieval test to use a schema 3.0 entity and the correct file purpose (test_should_upload_entity_file_and_retrieve).

Test utility improvements:

  • Introduced a build_company_v3_request helper to generate valid schema 3.0 company onboarding requests, reducing duplication and improving test maintainability.
  • Enhanced the upload_file utility to support customizable file purposes for more flexible test scenarios.

Serialization test coverage:

  • Added serialization tests for EEA Sole Trader representative documents, ensuring correct JSON structure and key presence, and validating that only accepted keys are declared in RepresentativeDocuments.
  • Added regression and edge case tests to verify omission of unset attributes and correct handling of None values in representative documents.
  • Added a test for serializing a controlling company as a representative, ensuring company structure is handled correctly.

Imports and dependency updates:

  • Updated imports in test files to include new document-related classes and enums required for the new tests. [1] [2]

@david-ruiz-cko
david-ruiz-cko requested a review from a team October 6, 2026 11:27
@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟡 Risk Classification: MINOR

Approval route: AI Review + Human Approval
Rollback controls: Staged rollout + rollback

Classification reasons

  • no_low_class_matched
  • prod_source_modified

Operational gates

  • ✅ jira_ticket
  • ✅ independent_review

Files analysed: 1


wall-e 2026.06.19-02 · policy 6b4ce2b3b45a…

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown
🔬 Debug — why this classification?

Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.

Reason code Kind Clause Meaning
no_low_class_matched informational §2.2 (fall-through) None of the deterministic Low classes (§2.2.3, §2.2.4, §2.2.7, docs-only) applied; classifier fell through to LLM evaluation.
prod_source_modified informational §2.1 M7 (informational) At least one file is non-doc, non-test, non-IaC — i.e. application source code was modified.

Kinds:

  • classifying — this rule contributed to the chosen tier.
  • informational — context only; did not by itself decide the tier.

See issue #3 for the proposal to formalise this map as Appendix A of the standards doc.

wall-e 2026.06.19-02 · debug

@agent-wall-e

agent-wall-e Bot commented Oct 6, 2026

Copy link
Copy Markdown

🟠 Advisory review: Concerns worth a look

This PR needs a human approval. Before you give it, these are the things I'd want resolved.

The diff only shows a version bump from 4.5.0 to 4.6.0, but the PR description claims significant test additions, new helper methods, serialization test coverage, and import updates — none of which appear in the diff.

Concerns

  • The diff is almost certainly partial or truncated: all the integration tests, serialization tests, utility methods, and import changes described in the PR body are missing from the review.
  • A reviewer cannot verify whether the described changes are correct, safe, or even present without seeing the full diff — approving based only on a version bump would be incomplete.

This is not an approval. wall-e cannot auto-approve this PR — it is an opinion to help whoever does. Advisory review · us.anthropic.claude-sonnet-4-6 · wall-e 2026.06.19-02

@sonarqubecloud

sonarqubecloud Bot commented Oct 6, 2026

Copy link
Copy Markdown

@david-ruiz-cko
david-ruiz-cko merged commit 8fe8c61 into main Oct 6, 2026
4 checks passed
@david-ruiz-cko
david-ruiz-cko deleted the release/4.6.0 branch October 6, 2026 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants