feat(payments): add fallback_source_used to PaymentProcessing and complete ProcessingData JavaDoc - #646
Open
armando-rodriguez-cko wants to merge 1 commit into
Open
Conversation
…ument ProcessingData PaymentResponse.processing declares fallback_source_used but the model lacked it. Also completes the JavaDoc of the 23 undocumented ProcessingData properties, which the class had been missing since it was introduced.
🟢 Risk Classification: LOWApproval route: AI Auto-Approval Classification reasons
Operational gates
Files analysed: 3 wall-e 2026.06.19-02 · policy |
🔬 Debug — why this classification?Each reason code emitted by the classifier, its source clause in the AI in SDLC Control Framework, and what it means.
Kinds:
See issue #3 for the proposal to formalise this map as Appendix A of the standards doc. wall-e 2026.06.19-02 · debug |
|
david-ruiz-cko
approved these changes
Aug 7, 2026
There was a problem hiding this comment.
✅ Auto-approved — this PR meets all Low-risk criteria.
All checks passed, no unresolved comments, and the change classification is:
no_low_class_matchedprod_source_modified2.2.6_logical_extension:The PR only adds one new optional Boolean field to an existing model class and JavaDoc comments to existing fields, with corresponding serialization tests — no new endpoints, persistence, auth changes, or external integrations are introduced.
wall-e 2026.06.19-02 · policy 376219bc71e6…
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
POST /paymentsreturnsPaymentResponse.processing, an inline schema distinct from theProcessingDataschema returned byGET /payments/{id}. The Java model for the former (PaymentProcessing) was complete except forfallback_source_used, which this PR adds (INT-1685).While auditing both models,
ProcessingDataturned out to have JavaDoc on only its last nine properties. The other 23 are documented here from the swagger, so the class is complete per the review-integrity doc-comment rule.Changes
src/main/java/com/checkout/payments/PaymentProcessing.java— addedfallbackSourceUsedsrc/main/java/com/checkout/payments/response/ProcessingData.java— JavaDoc for the 23 previously undocumented properties, including descriptions, constraints (localepattern and length,pan_type_processedenum values) and a note on the properties that are not in the public spec but are kept for backward compatibilitysrc/test/java/com/checkout/payments/PaymentProcessingSerializationTest.java—fallback_source_usedadded to the full swagger-example test, plus a dedicated deserialization test and a round-trip testAPI Reference
POST /payments—PaymentResponse.processing(inline schema)GET /payments/{id}—PaymentDetails.processing(ProcessingDataschema, documentation only)Breaking changes
None. One new optional response property, plus documentation.
README
No impact. The README does not document individual response fields.