fix: don't notify of missed call from blocked user - #8594
Open
WofWca wants to merge 1 commit into
Open
Conversation
Closes #8576. The diff might look big, but it's only two things: - move `can_call_me` one scope up - replace `emit_incoming_msg` with `emit_msg_event` with `important = can_call_me` I decided not to completely unify the `important` logic with the other occurrence of `emit_msg_event()` as I suggested in the issue yet. That IMO should still be considered, but let's start simple.
WofWca
force-pushed
the
wofwca/fix-blocked-stale-call-notif
branch
from
August 15, 2026 15:43
30ba86c to
0d256e0
Compare
WofWca
marked this pull request as ready for review
August 15, 2026 15:53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #8576.
The diff might look big, but it's only two things:
can_call_meone scope upemit_incoming_msgwithemit_msg_eventwith
important = can_call_meI decided not to completely unify the
importantlogicwith the other occurrence of
emit_msg_event()as I suggested in the issue yet.
That IMO should still be considered, but let's start simple.
Note that there is #7840 which may be closed by #7955,
which will basically supersede this MR.
I think, however, that it's OK to merge this one,
and then that one can just revert this one, including tests,
and rebase on top of the revert.