New build option for reconverse - #3926
Open
ritvikrao wants to merge 11 commits into
Open
Conversation
#3930) * reconverse-darwin-arm8: compile with C++17 (Apple clang defaults to C++98) Apple clang still defaults to gnu++98; reconverse headers require C++17. Append -std=gnu++17 to CMK_CXX_FLAGS and also to CMK_NATIVE_CXX_FLAGS / CMK_SEQ_CXX_FLAGS, because conv-mach-darwin.sh snapshots those from CMK_CXX_FLAGS before this arch script runs (charmxi builds with NATIVE). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * apply c++17 to all darwin builds --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Co-authored-by: Ritvik Rao <rsrao2@illinois.edu>
Ten phases of a message ring over all PEs, each ended by CkStartQD with a callback that starts the next phase — exercising QD's detect/reset/redetect cycle, which one-shot QD-at-exit usage never tests. A hang means QD state did not reset between detections. The printed qd_settle_ms doubles as a performance canary for transport idle-path latency: healthy runtimes settle in well under a millisecond at small scale; tens of milliseconds indicate the transport delays sparse single messages (measured on reconverse/LCI: ~12.7 ms per idle cross- process hop on IBV, ~5-10 ms on ofi/tcp, vs ~0.5 ms settles on classic netlrts in the same 2-process configuration). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
…l wrote no files) Reconverse's ConverseExit calls no trace hooks, so any trace module whose cleanup depends on the converse-driven global traceClose() silently writes nothing; trace-summary's per-PE .sum/.sumd writes live in SumLogPool's destructor, reached only from that path. Make summary self-closing from its exit function, mirroring the trace-projections pattern: a broadcast closeSummaryOnPe() disables the module, writes the .sts on PE 0, frees the log pool (which writes this PE's files), and reduces into CkContinueExit. In production use since 2026-07-28 (Anvil 80M/2B FoF runs, 120-1920 PEs). Full root-cause analysis and the general reconverse trace-shutdown lesson: UIUC-PPL/charm-notes reconverse-trace-shutdown.md. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
reconverse-darwin-arm8andreconverse-linux-x86_64as new build time options for the reconverse build.