You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Interlock* (which has the Arm64 barrier code, and the updated built-in for InterlockedExchange to use __atomic_exchange_n
Remove the OSX/BSD specific version of memmove. Not sure why that is necessary in the first place, because memmove should handle overlapping buffer already.
Replace all __declspec(noreturn) to DECLSPEC_NORETURN
Fix the macro in JnHelperMethodList.h to not have the trailing ## if there is nothing to concat
@rhuanjl I am curious about pulling this in, aside from being large, the change looks relatively straightforward.
We need to rebuild though - build history already expired :)
Some of the typedef changes don't work on macOS so we'll need to sort that other than that two things:
a) it's incomplete (though we could take it any way and progress from here)
b) need to ask @curtisman if his work here is covered by the existing license
@rhuanjl
a) yeah.. I don't have a macOS to work thru the build issues. Someone will have to take the change and work on it a bit.
b) the existing files in the PAL directory has their origin from the dotnet version here previously. Some of the updated in this change are to sync up the two. They are both licensed as MIT (and copyrighted MS), so I am not 100% whether addition license language needed to be added there. Otherwise, there is no addition license requirements.
Thanks @curtisman I'll pull it down and see if i can fix the macOS issues later this week.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PAL and WABT directory can build with GCC with this change.
InterlockedExchangeto use__atomic_exchange_n