Skip to content

ci(codeql): honor alert suppression comments #3745

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jiparis merged 1 commit into from
Oct 28, 2026
Merged

ci(codeql): honor alert suppression comments #3745

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,9 @@ jobs:
uses: github/codeql-action/init@6a28655e3dcb49cb0840ea372fd6d17733edd8a4 # v2.21.8
with:
languages: ${{ matrix.language }}
# The alert suppression query marks the alerts that a `// codeql[<query-id>]`
# comment covers with a SARIF suppressions field. The default queries still run.
packs: codeql/go-queries:AlertSuppression.ql

- name: Autobuild
uses: github/codeql-action/autobuild@6a28655e3dcb49cb0840ea372fd6d17733edd8a4 # v2.21.8
Expand Down
1 change: 1 addition & 0 deletions app/controlplane/internal/service/casredirect.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -308,5 +308,6 @@ func (s *CASRedirectService) setDownloadVerifierCookie(w http.ResponseWriter, fl
cookie.MaxAge = -1
cookie.Expires = time.Unix(1, 0)
}
// codeql[go/cookie-secure-not-set] Secure is true, and false only in development mode.
http.SetCookie(w, cookie)
}
1 change: 1 addition & 0 deletions internal/redaction/redaction.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -597,6 +597,7 @@ func (w *rewriter) redactLeaf(s, path string) string {
w.count += n

var out string
// codeql[go/unsafe-quoting] body is escaped by encodeStringBody, and the sink is a JSON decode.
if err := json.Unmarshal([]byte(`"`+body+`"`), &out); err != nil {
// A replacement cut through a JSON escape sequence. Drop the whole leaf
// rather than risk leaving part of the secret behind.
Expand Down
Loading