Skip to content

Fixed cleanup of stale cfbuild packages on build hosts (3.24.x) #2431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
larsewi wants to merge 1 commit into
base: 3.24.x
Choose a base branch
from
Open

Fixed cleanup of stale cfbuild packages on build hosts (3.24.x) #2431

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions ci/setup-cfengine-build-host.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,14 +124,15 @@ if [ -f /etc/os-release ]; then
elif grep -q suse /etc/os-release; then
zypper -n update
alias software='zypper install -y'
alias erase-packages='zypper uninstall -y'
alias erase-packages='zypper remove -y'
else
echo "Unknown platform ID $ID. Need this information in order to update/upgrade distribution packages."
exit 1
fi
elif [ -f /etc/redhat-release ]; then
yum update --assumeyes
alias software='yum install --assumeyes'
alias erase-packages='yum erase --assumeyes'
else
echo "No /etc/os-release or /etc/redhat-release so cant determine platform."
exit 1
Expand All @@ -146,6 +147,11 @@ else
exit 1
fi

# Must run before any cfengine-nova install below. The cfbuild-* packages own
# files under /var/cfengine, so leftovers make the agent install fail on file
# conflicts.
erase-packages cfbuild-* || true # in case a dirty build was left on a long-living build host

if grep -q 6.10 /etc/issue 2>/dev/null; then
# special case of centos-6, cf-remote depends on urllib3 which depends on openssl 1.1.1+ that is not available
# generally we rely on cf-remote to install cfengine-nova and download masterfiles so here we must provide for both of those
Expand Down Expand Up @@ -257,9 +263,6 @@ if ! /var/cfengine/bin/cf-agent -V 2>/dev/null; then
mv "$HOME"/.cfengine/cf-remote/* "$HOME"/.config/cfengine/cf-remote/
fi


erase-packages cfbuild-* || true # in case a dirty build was left on a long-living build host

# We are passing a two-token string and need it to stay two tokens for proper argument parsing in $_VERSION
# shellcheck disable=SC2086
cf-remote --log-level info $_VERSION install --clients localhost || true
Expand Down