ENT-14361: Added --label to build by Jenkins build label - #2425
Merged
Conversation
The build-in-container.py script already knows how a Jenkins label maps to a platform. Hence, an option to build based on a label makes it so that a Jenkins job does not also have to know this mapping. With this change, adding a platform will only require editing platforms.json and labels.txt. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
craigcomstock
approved these changes
Aug 12, 2026
| ./build-in-container.py --platform debian-12 --project nova --role hub --build-type RELEASE | ||
|
|
||
| # Alternatively, use Jenkins labels (see build-scripts/labels.txt) | ||
| ./build-in-container.py --label PACKAGES_HUB_x86_64_linux_debian_12 --project nova --build-type RELEASE |
Contributor
There was a problem hiding this comment.
For this case of HUB you don't need project nova, that is required.
I guess strangely, we don't have a distinction between community and enterprise platform labels. ok.
Might be interesting to consider changing this to --edition (community|enterprise)
Contributor
Author
There was a problem hiding this comment.
craigcomstock
approved these changes
Aug 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
build-in-container.pyscript already knows how a Jenkins label maps to a platform. Hence, an option to build based on a label makes it so that a Jenkins job does not also have to know this mapping.With this change, adding a platform will only require editing
platforms.jsonandlabels.txt.Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech