CFE-90: Replaced chown -R of the jenkins home with fixing root owned files - #2421
Merged
Merged
Conversation
craigcomstock
approved these changes
Aug 11, 2026
This reverts commit e19e324. The range was already correct on the CI hosts; setuid bits were lost to chown, not to the id mapping. Ticket: CFE-90 Changelog: none
chown -R cleared setuid bits, stripping /usr/bin/sudo inside every image in the rootless container store. The root owned files it existed for were this script's own: it ran from the jenkins home. Work in /var/tmp instead. Ticket: CFE-90 Changelog: none
nickanderson
force-pushed
the
CFE-90/master-3
branch
from
August 12, 2026 16:41
48beb18 to
6a8e329
Compare
nickanderson
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pre-build
chown -R jenkins /home/jenkinswalked the rootless container store, andchown(2)clears setuid bits even when the owner is unchanged, so/usr/bin/sudoinside stored image layers lost its setuid bit and every container build that reused an image failed. The root owned files it was compensating for were this script's own, left in the jenkins home because it ran from there; it now works in/var/tmpand chowns only what is still root owned, reporting it.Also reverts e19e324, which addressed the same failure on the wrong premise: the subuid range was already correct on the CI hosts.