Skip to content

Document ACME Challenge and Order RBAC restriction for v1.21 - #2184

Merged
cert-manager-prow[bot] merged 1 commit into
cert-manager:release-nextfrom
wallrj-cyberark:GHSA-8rvj-mm4h-c258-rbac-docs
Jun 29, 2026
Merged

Document ACME Challenge and Order RBAC restriction for v1.21#2184
cert-manager-prow[bot] merged 1 commit into
cert-manager:release-nextfrom
wallrj-cyberark:GHSA-8rvj-mm4h-c258-rbac-docs

Conversation

@wallrj-cyberark

@wallrj-cyberark wallrj-cyberark commented Jun 29, 2026

Copy link
Copy Markdown
Member

Preview:

Summary

  • Add cert-manager-edit ClusterRole RBAC restriction note to release-notes-1.21.md, referencing security advisory GHSA-8rvj-mm4h-c258 (HIGH) and noting that this was already shipped in v1.20.3 and v1.19.6
  • Add corresponding upgrade note to upgrading-1.20-1.21.md

Motivation

cert-manager/cert-manager#8958 merged the RBAC restriction into master. This documents the potentially breaking change for v1.21, matching the notes already written for the v1.20.3 patch release (#2174).

Test plan

  • Netlify deploy preview renders correctly
  • Release notes page shows GHSA-8rvj-mm4h-c258 advisory link and "Potentially breaking change" section
  • Upgrade notes page (upgrading-1.20-1.21) shows RBAC restriction note
  • Spellcheck passes

@cert-manager-prow

Copy link
Copy Markdown
Contributor

@wallrj-cyberark: The label(s) area/website cannot be applied, because the repository doesn't have them.

Details

In response to this:

Summary

  • Add release notes section documenting the removal of Challenge create and
    Order create/patch/update permissions from the cert-manager-edit
    aggregate ClusterRole (GHSA-8rvj-mm4h-c258).
  • Add corresponding entry to the v1.20 → v1.21 upgrade guide.

Motivation

cert-manager/cert-manager#8958 merged the RBAC change into master. This is a
breaking change for any user or tooling that creates Challenge or Order
resources directly (not a supported workflow, but the permissions previously
existed in the aggregate ClusterRole).

Test plan

  • Verified the Markdown renders correctly with the existing release notes and
    upgrade guide structure.

/area website

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@cert-manager-prow cert-manager-prow Bot added dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jun 29, 2026
@netlify

netlify Bot commented Jun 29, 2026

Copy link
Copy Markdown

Deploy Preview for cert-manager ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit a0cec0d
🔍 Latest deploy log https://app.netlify.com/projects/cert-manager/deploys/6a42c9584ca1e600073553ff
😎 Deploy Preview https://deploy-preview-2184--cert-manager.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@wallrj-cyberark
wallrj-cyberark force-pushed the GHSA-8rvj-mm4h-c258-rbac-docs branch from 92226e3 to 63b3e5d Compare June 29, 2026 18:30
@wallrj-cyberark
wallrj-cyberark requested a review from wallrj June 29, 2026 18:34
@wallrj-cyberark wallrj-cyberark changed the title Document ACME Challenge and Order RBAC breaking change Document ACME Challenge and Order RBAC restriction for v1.21 Jun 29, 2026
@wallrj-cyberark
wallrj-cyberark force-pushed the GHSA-8rvj-mm4h-c258-rbac-docs branch from 63b3e5d to 53b4fb4 Compare June 29, 2026 19:05
Signed-off-by: Richard Wall <richard.wall@cyberark.com>
@wallrj-cyberark
wallrj-cyberark force-pushed the GHSA-8rvj-mm4h-c258-rbac-docs branch from 53b4fb4 to a0cec0d Compare June 29, 2026 19:36
@wallrj

wallrj commented Jun 29, 2026

Copy link
Copy Markdown
Member

/approve
/lgtm

@cert-manager-prow

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wallrj

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@cert-manager-prow cert-manager-prow Bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 29, 2026
@cert-manager-prow
cert-manager-prow Bot merged commit 99f87fa into cert-manager:release-next Jun 29, 2026
7 checks passed
@wallrj-cyberark
wallrj-cyberark deleted the GHSA-8rvj-mm4h-c258-rbac-docs branch June 29, 2026 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes Indicates that all commits in the pull request have the valid DCO sign-off message. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants