Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug
Subtitle.indexsupportsNone, andparse()accepts missing indexes. However, when two subtitles have the same start and end times,Subtitle.__lt__directly compares their indexes. Mixing an indexed and unindexed subtitle raisesTypeErrorinsort_and_reindex()and the defaultcompose()path.For example:
Fix
Normalize missing indexes to zero in the comparison key, matching
to_srt()'s existing fallback. Preserve numeric index ordering and stable order for equal fallback keys; do not mutate the input subtitles.Validation
TypeError; the all-None control passes.python -m pytest -q --doctest-modules— 60 passed on Python 3.12.10 (pytest 9.1.1, Hypothesis 6.168.3). Original tests alone passed on the unmodified baseline (45).srt.pyreports one pre-existing extra blank line near the imports, identically on the unmodified baseline; left that unrelated line untouched.AI assistance was used to investigate, implement, and test this change. All examples are synthetic; no private subtitle data is included.