fixes - #1813
Merged
Merged
Conversation
SFJohnson24
requested review from
RamilCDISC,
Copilot,
gerrycampion and
pendingintent
and removed request for
Copilot
July 28, 2026 18:17
RamilCDISC
requested changes
Jul 28, 2026
Collaborator
There was a problem hiding this comment.
The CSV files seems like debug artifacts. Could you please remove them or mention in a comment why they were made part of the PR?
Collaborator
Author
There was a problem hiding this comment.
they are artifacts-- I added #1802 the csv in the gitignore but i also added it to this branch
| relrec_row, left_dataset, datasets, dataset_preprocessor, wildcard | ||
| ) | ||
| for _, relrec_row in relrec_for_domain.iterrows() | ||
| for relrec_row in relrec_for_domain.to_dict("records") |
Collaborator
There was a problem hiding this comment.
The merge on relrec record function still has
def merge_on_relrec_record( relrec_row: pd.Series, ...
the type hint is outdated as it is changed to type dict here now.
RamilCDISC
approved these changes
Jul 29, 2026
RamilCDISC
left a comment
RamilCDISC
left a comment
Collaborator
There was a problem hiding this comment.
The PR fixes .itterrows() bug identifies and explained in the PR description. The updated code was validated by:
- Ensuring the PR is in accordance with AC.
- Ensuring the PR doe snot have any unwanted code or comments.
- Ensuring the PR updated code integrates with existing flow.
- Ensuring the type hints and function calls chain to be maintained.
- Ensuring all unit and regression tests pass.
- Running manual validation on the tests data, using positive and negative datasets.
- Ensuring the outputs of the rule execution are valid.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR fixes CORE-000757 expected not matching actual. DataFrame.iterrows() silently upcasts blank RELREC values (like an all-empty USUBJID column) from None to float NaN, and since filter_if_present treated NaN as a real filter to apply, the RELREC-to-CM merge in CORE-000757 wiped out the whole dataset
to test:
run CORE-000757 on this branch with test data--no longer gives skip; gives expected result from dataset
also fixes CORE-000744 negative 01-04