Fix dropping of error locations#37
Open
cchalmers wants to merge 2 commits into
Open
Conversation
Since #14 the error locations often pointed to the end of the circuit instead of the correct location. That should now be fixed, along with a regression test.
Collaborator
|
Cool! I did find an issue in the meantime, but I have yet to make a minimal reproducer out of it. I'll have a look. Perhaps for testing you can use this structure: and That way it doesn't just run in Nix. |
The error-location test shells out to ghc to compile a fixture with the plugin enabled. During the package's own nix check phase circuit-notation isn't registered in any package database, so that compile cannot succeed and the test would fail the build. Probe ghc first and skip (rather than fail) when it can't compile against the plugin; the test still runs for real under cabal test, where the package environment file makes the plugin available. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
cchalmers
force-pushed
the
fix-error-locations
branch
from
b6fd712 to
f83ef95
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #14 the error locations often pointed to the end of the circuit instead of the correct location. That should now be fixed, along with a regression test.
Hopefully resolves #35.