Skip to content

Port bounded auto-review detail shape#148

Open
shiny-code-bot wants to merge 1 commit into
mainfrom
code/pr79-auto-review-detail-shape
Open

Port bounded auto-review detail shape#148
shiny-code-bot wants to merge 1 commit into
mainfrom
code/pr79-auto-review-detail-shape

Conversation

@shiny-code-bot

Copy link
Copy Markdown
Collaborator

Summary

  • Port the bounded auto-review detail surface to the Every Code feature shape: optional run-level reads plus specific finding reads.
  • Return LLM-friendly formatted detail text instead of pretty JSON, with explicit detailKind, findingCount, and omittedFindings metadata.
  • Preserve current Codex Lab safety rules: scoped store lookup, completed/current target gating, hard byte caps, and strict present-but-empty findingId rejection.
  • Regenerate app-server protocol JSON/TypeScript schemas.

Verification

  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-auto-review
  • cargo check --manifest-path codex-rs/Cargo.toml -p codex-app-server-protocol -p codex-app-server
  • just write-app-server-schema
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-app-server-protocol schema_fixtures_match_generated
  • cargo test --manifest-path codex-rs/Cargo.toml -p codex-app-server --test all auto_review_finding_detail_read
  • cargo fmt --manifest-path codex-rs/Cargo.toml --all -- --check
  • git diff --check

Part of #126.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants