perf(progress): throttle print_progress to 1 Hz instead of every pair - #50
Merged
Conversation
Merging this PR will degrade performance by 28.1%
|
| Benchmark | BASE |
HEAD |
Efficiency | |
|---|---|---|---|---|
| ❌ | test_detrend_method[z_score-p10] |
1.2 ms | 1.7 ms | -28.1% |
Tip
Investigate this regression by commenting @codspeedbot fix this regression on this PR, or directly use the CodSpeed MCP with your agent.
Comparing perf/throttle-progress (9e22ecd) with main (8119494)
Pass the new last_print shared value to _compute_with_progress and add parametrized tests covering the 1 Hz throttle branches in both the sequential and parallel paths. Extract a shared-memory helper to avoid repeating setup code.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #50 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 29 29
Lines 851 859 +8
Branches 147 149 +2
=========================================
+ Hits 851 859 +8 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously
print_progresswas called after every single pair, flushing stdout each time. For a 100-node network that's 9,900 flushes. significant stdbuf overhead.Replace with rate-limited output: print at most once per second, with a final forced print on the last pair. Applies to both sequential and parallel paths.
Mechanism: track
last_printtimestamp; only callprint_progresswhen at least 1 second has elapsed (or it's the final pair). UsesManager.Valuein the parallel path for cross-process sharing.