Repository navigation
docs: the tree has C dependencies, it links no system libraries - #21
Merged
Merged
Conversation
requirements.md and architecture.md said there were no C dependencies at all. zstd, ring and mimalloc are built from C; what holds is that they are built from source and linked statically, so the binary needs nothing on the machine that runs it. installation.md already said a C compiler was needed and now names mimalloc too. Claude-Session: https://claude.ai/code/session_01LtsaMBeethcCYvKx8PTBYL
![cbox-agents[bot]](https://avatars.githubusercontent.com/u/19936443?s=60&v=4){kind=small}
There was a problem hiding this comment.
Findings outside the changed lines:
docs/security/_index.md:72: This file still says there are no C-toolchain dependencies at all, which contradicts the corrected docs. Doesn't block the merge, but it should be fixed.
Rewrite the sentence to say the three C dependencies (zstd,ring, mimalloc) are built from source and linked statically, with no system libraries, and drop the claim that a whole class of vulnerability is avoided.SECURITY.md:124: SECURITY.md still says telemetryd has no C-toolchain dependencies at all, so it contradicts this change. Doesn't block the merge.
Change the line to say telemetryd links no system libraries: its three C dependencies (zstd,ring, mimalloc) are built from source and linked statically.
Talking to Cbox
- Reply under a finding to ask Cbox about it.
/cbox fixin reply to a finding: Cbox fixes it on this pull request's branch, or, when it can't push there, on a new branch whose push waits for a confirm in Cbox./cbox reviewreviews this pull request again now./cbox <question>asks Cbox about this pull request./cbox helpshows this list.
Only people who can push to this repository and have linked their GitHub account in Cbox can use /cbox.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
requirements.md,architecture.mdandextension-pointssaid there were no C dependencies. zstd,ringand mimalloc are built from C. What holds is that they are linked statically, so nothing is needed on the host.https://claude.ai/code/session_01LtsaMBeethcCYvKx8PTBYL