Enable DuplicateDependingFindingsTest#468
Merged
san-zrl merged 3 commits intoJun 17, 2026
Merged
Conversation
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
somiljain2006
force-pushed
the
enable-duplicate-depending-findings-test
branch
from
15fa491 to
49c9b15
Compare
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
somiljain2006
force-pushed
the
enable-duplicate-depending-findings-test
branch
from
fe392c3 to
9ca13d5
Compare
Signed-off-by: somiljain2006 <somil16022006@gmail.com>
somiljain2006
force-pushed
the
enable-duplicate-depending-findings-test
branch
from
9e26e21 to
dfb9a0a
Compare
Contributor
Author
|
@san-zrl Can you review this pr? |
san-zrl
approved these changes
Jun 17, 2026
san-zrl
left a comment
san-zrl
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. Thank you.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables
DuplicateDependingFindingsTest, which was previously disabled due to duplicate depending detection rules being propagated fromOAEPEncodingto its childRSAEngine. The test assertions have been updated to verify that theinitdepending detection rule is only associated withOAEPEncodingand not the underlying engine. This adds regression coverage and helps prevent duplicate findings from being reintroduced.Also fixed spotless errors in PycaDigestContextTranslator.java