This PR implements native C/C++ support for the sonar-cryptography plugin using an ANTLR4-based architecture, addressing issue #374.#391
Conversation
|
Hi @Ndugu2 - Thank you for you interest in CBOMkit and your contribution. Perhaps you noted that we have PR #377 that provides language support for C/C++ baed on Sonar (similarly to the language support for Java, Python and Go). We are actively working on merging this PR into CBOMkit in response to issue #374. Your PR would duplicate our efforts for C/C++ support. |
|
Thanks for the contribution, but this PR has some structural issues that make it hard to review or merge as-is. I'm closing it and would ask you to reopen as smaller, focused PRs. High-level points: 1. Vendored Maven distribution committed. 2. Stray C# ANTLR parser. Under 3. Token files in the wrong location. 4. Generated ANTLR sources committed. Both the 5. Mixing concerns. This PR bundles at least four unrelated changes:
Each should be its own PR so they can be reviewed independently. 6. 7. PR is from 8. PR title. The title is a full sentence; please shorten it and move the detail to the body. Suggested follow-upPlease open separate PRs from feature branches for:
Looking forward to the cleaned-up versions. |
Key Changes:
cxxmodule into the main plugin build.Fixes #374