Repository navigation
fix(dashkit): address interface review findings on critical interactive components - #12
Merged
Merged
Conversation
…ve components - add visible focus rings to Button, Accordion, Tabs, Sidebar, NavigationMenu, ButtonGroup, ColorPicker and Slider (WCAG 2.4.7/1.4.11) - add accessible names: Toast close, ColorPicker swatches and hex input, Sidebar toggle, OtpInput digits, CopyField label association (4.1.2) - keep collapsed Sidebar item text in the accessibility tree (4.1.2) - make Chip keyboard-operable via a native button / role=button (2.1.1) - open hover Popovers from focus and blur (2.1.1) - honor prefers-reduced-motion with MotionConfig and a CSS fallback (2.3.3) - replace text-ds-400 with text-ds-600 dark:text-ds-400 on light surfaces (measured 2.56:1 on white, 2.33:1 on ds-100; 1.4.3/1.4.11) - make the Toast close button reachable (group class, focus opacity, larger hit area), keep error toasts until dismissed, pause timers on hover/focus and stop truncating toast content (2.2.2/2.4.7) - label Modal and Drawer dialogs with labelledBy/label props (4.1.2) - move focus into Dropdown and Select popups on open and restore it to the trigger on close; drop the mismatched aria-haspopup=menu (2.4.3/4.1.2) - add listbox/combobox keyboard and ARIA support: arrows/Home/End, Enter, aria-activedescendant, option roles, label association (2.1.1/4.1.2) - link error and helper text to fields with aria-invalid/aria-describedby - render inputs at 16px below the sm breakpoint to prevent iOS zoom (1.4.4) - enlarge hit areas on Chip delete, Combobox clear and Toast close (2.5.8)
✅ Deploy Preview for dashkit ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses critical accessibility (a11y) and interface review findings across interactive components in Dashkit:
Verification