Repository navigation
Start the demo even when the SoundCloud playlist fails to load - #1389
Merged
Merged
Conversation
SoundCloud's API now answers our client id with a 401, so getPlaylist resolved to an error body and tracksFromPlaylist threw reading `tracks.map`. That stopped the demo from starting at all for any ?scPlaylist= link, including /poolside. Treat a failed or malformed response as an error, and fall back to the default tracks. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
|
Size Change: 0 B Total Size: 491 kB ℹ️ View Unchanged
|
✅ Deploy Preview for tourmaline-kringle-c98715 canceled.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Any webamp.org link with
?scPlaylist=fails to start: the desktop icons render but Webamp never appears. That includes the/poolsideredirect innetlify.toml. In Sentry this is WEBAMP-1T9 (TypeError: Cannot read properties of undefined (reading 'map')), and every recent event hasscPlaylist=1040356177, the Poolside playlist.SoundCloud's API now answers our client id with
401.getPlaylistreturned the error body as if it were a playlist, thentracksFromPlaylistthrew onplaylist.tracks.mapbefore Webamp was constructed.This makes
getPlaylistthrow on a non-OK response or one without atracksarray, andmain()catches that, logs it, and carries on with the default tracks. The skin and background from the URL still apply. It also removes a@ts-ignorethat is no longer needed.This only keeps the page working. The SoundCloud feature itself is still dead: getting the Poolside tracks back needs a different source, or the
scPlaylistparam removed from the/poolsideredirect.Steps to reproduce (on webamp.org today)
/?bg=%2362639f&scPlaylist=1040356177&skinUrl=…).Cannot read properties of undefined (reading 'map').curl -s -o /dev/null -w "%{http_code}" "https://api.soundcloud.com/playlists/1040356177?client_id=T9EbIJ75SnsJK3iX8lOZaDlGIYgQB32G"prints401.Test plan
#62639fbackground and the default playlist. The console logsError: SoundCloud playlist request failed: 401and nothing else from startup.eslintandprettier --checkpass. The demo'stscerrors are unchanged: the two existing PNG-import errors inDemoDesktop.tsx.🤖 Generated with Claude Code