[Misc] Added Workzone service to helm chart - #120
Draft
anirudhprasad-sap wants to merge 6 commits into
Draft
Conversation
- Add files/workzone.yaml.hbs with build-workzone-standard service instance and binding templates - Update lib/add.js: detect hasWorkzoneStandard and include workzone.yaml.hbs in combine() - Update files/approuter.yaml.hbs: add workzone-bind to consumedBTPServices and OWN_SAP_CLOUD_SERVICE env var - Update files/workloads.yaml.hbs: add workzone-bind to contentDeploy consumedBTPServices and ASYNC_UPLOAD=true env var
…ne-standard in cap-operator chart
![hyperspace-pr-bot[bot]](https://avatars.githubusercontent.com/u/2531208?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
The PR introduces workzone-standard support but has several correctness issues: {{strippedAppName}} is an undefined Mustache variable that will render literally instead of being substituted, hasWorkzoneStandard appears to never be populated by readProject() meaning the feature will silently be skipped, and the new test case mutates the shared bookshop fixture without cleanup, risking interference with subsequent tests that compare against fixed YAML snapshots.
PR Bot Information
Version: 1.29.26
- File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet - Correlation ID:
07db3be0-9659-11f1-883c-3db67b910bc0
…d; add validation for providerId length in tests
…y in workloads.yaml.hbs and update related test assertions
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add SAP Build Work Zone Standard Edition Support to Helm Chart
New Feature
✨ Adds support for SAP Build Work Zone, Standard Edition (
workzone-standard) to the CAP Operator Helm chart plugin (v0.20.0). When enabled, the plugin generates abuild-workzone-standardservice instance (local-entry-pointplan) and its binding, and updates the relevant workloads accordingly.Changes
files/workzone.yaml.hbs: New Mustache template defining thebuild-workzone-standardservice instance and binding, withproviderId(truncated to 20 chars) andexposureIdparameters derived from the app name.files/approuter.yaml.hbs: Added conditional inclusion of the workzone binding inconsumedBTPServicesand injects theOWN_SAP_CLOUD_SERVICEenvironment variable when Workzone Standard is enabled.files/workloads.yaml.hbs: Added conditional inclusion of the workzone binding in thecontentDeployjob'sconsumedBTPServiceswhen Workzone Standard is enabled.lib/add.js: ExtractedhasWorkzoneStandardfrom the project descriptor; computesworkzoneProviderId(app name, max 20 chars) and conditionally mergesworkzone.yaml.hbsintovalues.yamlduring thecombinestep.test/add.test.js: Added integration test verifying correct generation of the Workzone service instance, binding, approuterOWN_SAP_CLOUD_SERVICEenv var, and content deploy binding whenworkzone-standardis added.CHANGELOG.md: Added entry for version0.20.0documenting the new Workzone Standard support.package.json/package-lock.json: Bumped version from0.19.0to0.20.0.PR Bot Information
Version:
1.29.26pull_request.editedanthropic--claude-4.6-sonnet10bb64f0-96f0-11f1-9b9b-f6f21fe50925