Repository navigation
Complete CASE expression keywords with nested branch context - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQL completion currently misses the branch keywords in CASE expressions, such as
THENafterCASE WHEN amount > 100. This change tracks the active CASE expression and its WHEN/THEN/ELSE state so the appropriate keyword is offered without prioritizing an unrelated column.Nested CASE expressions and SELECT scopes remain separate. Expressions inside each branch continue to use normal column, alias and function completion. Query execution is unchanged.
Validation covers simple and searched CASE expressions, all four suggestion modes, nested cases, qualified keyword columns, comments and strings, plus completed SQL executed in SQLite. Hidden application tests exercise native Tab acceptance and preserve responsiveness with large SQL and result tables.