Repository navigation
Complete SELECT aliases in ORDER BY and HAVING - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Local completion currently misses SELECT output aliases in ORDER BY and HAVING. This change recognizes names such as
SUM(amount) AS total_revenue, so typingtotin those clauses offerstotal_revenue.Quoted and Unicode names, aggregate expressions and bare output aliases are supported. Ambiguous duplicate aliases are excluded, and aliases remain inside their SELECT scope. SQL execution and repair paths are unchanged.
Validation: regression tests cover all four suggestion modes, scope isolation, existing schema columns and accepted queries executed in SQLite. Hidden packaged-application tests verify native Tab acceptance, quoted names, syntax colours and responsiveness with a 240,000-character script and 5,000 result rows. The branch's full Source verification workflow passed before this PR was opened.
Includes bilingual release notes for 3.4.270.
Closes #1
Branch CI: https://github.com/canyrtcn/PractiSQL/actions/runs/40563627746