Skip to content

Type annotations in cloudinit.distros.Distros#6938

Open
rayterion wants to merge 7 commits into
canonical:mainfrom
rayterion:annotation/5445
Open

Type annotations in cloudinit.distros.Distros#6938
rayterion wants to merge 7 commits into
canonical:mainfrom
rayterion:annotation/5445

Conversation

@rayterion

@rayterion rayterion commented Jul 16, 2026

Copy link
Copy Markdown

Proposed Commit Message

refactor: add type hints for the distros module

as requested in #5445 

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@holmanb

holmanb commented Jul 16, 2026

Copy link
Copy Markdown
Member

Please sign the CLA. Also, type annotations are only useful if they are used by mypy.

@rayterion

Copy link
Copy Markdown
Author

i've signed the CLA. I'll proceed by adding the types and checking them with mypy through tox.

@rayterion
rayterion marked this pull request as ready for review July 18, 2026 18:52
@rayterion

Copy link
Copy Markdown
Author

Note: mypy is still running into errors, so this PR is still not ready to merge

@rayterion

Copy link
Copy Markdown
Author

Update: I've successfully identified the issues and have finished the task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants