Skip to content

feat: add ELN support to distros#6922

Open
yselkowitz wants to merge 1 commit into
canonical:mainfrom
yselkowitz:eln
Open

feat: add ELN support to distros#6922
yselkowitz wants to merge 1 commit into
canonical:mainfrom
yselkowitz:eln

Conversation

@yselkowitz

@yselkowitz yselkowitz commented Jul 3, 2026

Copy link
Copy Markdown

Proposed Commit Message

feat: add ELN support to distros

ELN now identifies itself uniquely and more RHEL-like, rather than as a 
variant of Fedora.

https://github.com/fedora-eln/eln/issues/565

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

@yselkowitz yselkowitz mentioned this pull request Jul 3, 2026
Closed
@yselkowitz
feat: add ELN support to distros
570513c 
ELN now identifies itself uniquely and more RHEL-like, rather than as a
variant of Fedora.

fedora-eln/eln#565

Signed-off-by: Yaakov Selkowitz <yselkowi@redhat.com>
blackboxsw
blackboxsw requested changes Jul 13, 2026
View reviewed changes

@blackboxsw blackboxsw left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for promoting this change in upstream cloud-init.

I think we are missing a couple of unittest conditions:

  • parametrized test case in tests/unittest/test_util.py::TestGetVariant for ELN
  • tests/unittests/config/test_cc_ntp.py add a test case for test_distro_ntp_client_config_eln

Additionally, please make sure the suggested commit message calls out any CentOS fixes proposed herein as well.

Comment thread systemd/cloud-init-local.service.tmpl
Before=network-pre.target
Before=shutdown.target
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "rhel"] %}
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "centos", "eln", "rhel"] %}

@blackboxsw blackboxsw Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These incidental CentOS fixes should be documented in this pull request suggested commit message to represent this changeset more conspicuousloy in git logs.

@holmanb holmanb Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on CentOS?

Comment thread systemd/cloud-init-main.service.tmpl
DefaultDependencies=no
{% endif %}
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "rhel"] %}
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "centos", "eln", "rhel"] %}

@blackboxsw blackboxsw Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These incidental CentOS fixes should be documented in this pull request suggested commit message to represent this changeset more conspicuousloy in git logs.

@holmanb holmanb Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on CentOS?

Comment thread cloudinit/config/cc_resolv_conf.py
"distros": [
"alpine",
"azurelinux",
"centos",

@blackboxsw blackboxsw Jul 13, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make sure we document any centos-related driveby fixes in this suggested pull request commit message.

@holmanb holmanb Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on CentOS?

holmanb
holmanb requested changes Jul 14, 2026
View reviewed changes

@holmanb holmanb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please provide cloud-init logs from a booted ELN instance.

The same for CentOS, too.

Comment thread systemd/cloud-init-local.service.tmpl
Before=network-pre.target
Before=shutdown.target
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "rhel"] %}
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "centos", "eln", "rhel"] %}

@holmanb holmanb Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on CentOS?

Comment thread systemd/cloud-init-main.service.tmpl
DefaultDependencies=no
{% endif %}
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "rhel"] %}
{% if variant in ["almalinux", "azurelinux", "cloudlinux", "centos", "eln", "rhel"] %}

@holmanb holmanb Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on CentOS?

Comment thread cloudinit/config/cc_resolv_conf.py
"distros": [
"alpine",
"azurelinux",
"centos",

@holmanb holmanb Jul 14, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has this been tested on CentOS?

@blackboxsw blackboxsw self-assigned this Jul 14, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blackboxsw blackboxsw blackboxsw requested changes
@holmanb holmanb holmanb requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@blackboxsw blackboxsw

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yselkowitz @blackboxsw @holmanb