feat: add validate-release debug command - #314
Open
upils wants to merge 2 commits into
Open
Conversation
niemeyer
requested changes
Aug 7, 2026
niemeyer
left a comment
Contributor
There was a problem hiding this comment.
It seems okayish to have this, but I wonder a bit about the motivation. We already have tests constantly running against the archive in a workflow, so ideally we should never have the situation where this would return false.
Either way, we can have this. Let's please just add one note to the description to try to avoid having issues:
This command, as any other command under debug, is unstable and will likely
be removed inside a major release with no warnings. Do not build scripts on it.
| return err | ||
| } | ||
|
|
||
| fmt.Fprintln(Stdout, "Release is valid") |
Contributor
There was a problem hiding this comment.
Do we have a convention established for such messages? Lower/upper? Punctuation?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch adds a new
chisel debug validate-releasecommand that performs static validation of a Chisel release — checkingchisel.yamland the slice definition files for structural issues (path conflicts, essential loops, invalid prefer relationships, archive priority conflicts, etc.) without downloading any package.Previously, validating a release could only be done indirectly by invoking a command that performs substantial additional work (
cutbuilds a rootfs,find/infoquery slices,debug check-release-archivesdownloads.debpackages and inspects tarball contents). This is awkward for slice definition authors iterating locally, for CI onchisel-releasesPRs, and for reviewers wanting quick feedback — all of whom benefit from a fast check that surfaces the descriptive errors fromvalidate()directly.