Skip to content

feat: add validate-release debug command - #314

Open
upils wants to merge 2 commits into
canonical:mainfrom
upils:validate-debug
Open

feat: add validate-release debug command#314
upils wants to merge 2 commits into
canonical:mainfrom
upils:validate-debug

Conversation

@upils

@upils upils commented Jul 24, 2026

Copy link
Copy Markdown
Collaborator
  • Have you signed the CLA?

This branch adds a new chisel debug validate-release command that performs static validation of a Chisel release — checking chisel.yaml and the slice definition files for structural issues (path conflicts, essential loops, invalid prefer relationships, archive priority conflicts, etc.) without downloading any package.

Previously, validating a release could only be done indirectly by invoking a command that performs substantial additional work (cut builds a rootfs, find/info query slices, debug check-release-archives downloads .deb packages and inspects tarball contents). This is awkward for slice definition authors iterating locally, for CI on chisel-releases PRs, and for reviewers wanting quick feedback — all of whom benefit from a fast check that surfaces the descriptive errors from validate() directly.

@upils upils added the Simple Nice for a quick look on a minute or two label Jul 24, 2026

@niemeyer niemeyer left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems okayish to have this, but I wonder a bit about the motivation. We already have tests constantly running against the archive in a workflow, so ideally we should never have the situation where this would return false.

Either way, we can have this. Let's please just add one note to the description to try to avoid having issues:

This command, as any other command under debug, is unstable and will likely
be removed inside a major release with no warnings. Do not build scripts on it.

return err
}

fmt.Fprintln(Stdout, "Release is valid")

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a convention established for such messages? Lower/upper? Punctuation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Simple Nice for a quick look on a minute or two

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants