Skip to content

feat: abstract interactions with archive/store - #311

Open
upils wants to merge 5 commits into
canonical:mainfrom
upils:slicer-source-interface
Open

feat: abstract interactions with archive/store#311
upils wants to merge 5 commits into
canonical:mainfrom
upils:slicer-source-interface

Conversation

@upils

@upils upils commented Jul 15, 2026

Copy link
Copy Markdown
Collaborator
  • Have you signed the CLA?

This branch introduces a pkgSource struct in the slicer that abstracts package fetching via a closure, replacing the previous direct map[string]archive.Archive lookup. This is needed because packages can now come from either archives or stores, and the slicer's Run function must handle both in a generic way. The closure captures the resolved archive or a store error (until the store is implemented) at resolution time, keeping Run source-agnostic. Store packages are not yet fetchable and return a clear "not implemented" error, with a test covering this path.

This lays the groundwork for implementing store fetching without further changes to the slicer's core logic.

upils#21 implements another approach to solve this, relying on a Source interface and a FetchOption marker interface. This approach seems more convoluted without obvious major advantages.

upils added 3 commits July 10, 2026 15:58
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
@upils upils added the Priority Look at me first label Jul 15, 2026
@upils upils changed the title feat: abstract interactions on archive/store feat: abstract interactions with archive/store Jul 15, 2026
Comment thread internal/slicer/slicer.go
// fetch function returning the package reader and metadata. The fetch
// function is bound at resolution time, so callers are agnostic to whether
// the package comes from an archive or a store.
type pkgSource struct {

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note to reviewer]: This struct could be extracted to a dedicated package and exported since in the future this abstraction might be useful in other packages, such as cmd_debug_check_release_archives.go.

Comment thread internal/slicer/slicer.go
// the package comes from an archive or a store.
type pkgSource struct {
arch string
fetch func() (io.ReadSeekCloser, *archive.PackageInfo, error)

@upils upils Jul 15, 2026

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[Note to reviewer]: If we adopt this approach, PackageInfo should likely be extracted to its own package as it will not be specific to the archive anymore and should also be usable by the future store package. This is slightly tangential to changes of this PR so I deffered this change for now.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #316

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure it makes sense to have PackageInfo itself to be extracted to a different package, because by the end of the day an apt package archive has package info data, and this needs to be concretely somewhere. The alternative is that we create a common ground type, but these often end up very messy because the become the union of all needs of all backends. It seems better to extend the approach that we are already pursuing here: interfaces that encapsulate only what actually needs to be common across them.

I'll take this comment to continue into a more general direction: this PR as a whole is playing with the right ideas and going into the right direction, but it's not yet nailing a proper encapsulation and abstraction approach to implement what we must. It doesn't make sense for the slider to be the one defining how to fetch packages and how to fetch stores, by injecting a lambda with custom code for either. The slider is precisely the thing that shouldn't care about the detais, and should instead be calling out in a single way towards multiple implementations.

So again, you're probably in the right ground, but needs some tuning still.

upils added 2 commits July 15, 2026 15:52
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Signed-off-by: Paul Mars <paul.mars@canonical.com>
Comment thread internal/slicer/slicer.go
// the package comes from an archive or a store.
type pkgSource struct {
arch string
fetch func() (io.ReadSeekCloser, *archive.PackageInfo, error)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure it makes sense to have PackageInfo itself to be extracted to a different package, because by the end of the day an apt package archive has package info data, and this needs to be concretely somewhere. The alternative is that we create a common ground type, but these often end up very messy because the become the union of all needs of all backends. It seems better to extend the approach that we are already pursuing here: interfaces that encapsulate only what actually needs to be common across them.

I'll take this comment to continue into a more general direction: this PR as a whole is playing with the right ideas and going into the right direction, but it's not yet nailing a proper encapsulation and abstraction approach to implement what we must. It doesn't make sense for the slider to be the one defining how to fetch packages and how to fetch stores, by injecting a lambda with custom code for either. The slider is precisely the thing that shouldn't care about the detais, and should instead be calling out in a single way towards multiple implementations.

So again, you're probably in the right ground, but needs some tuning still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Priority Look at me first

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants