feat(redis): add setKeyIfNotExists for one-time claims - #726
Open
Anshumancanrock wants to merge 1 commit into
Open
feat(redis): add setKeyIfNotExists for one-time claims#726Anshumancanrock wants to merge 1 commit into
Anshumancanrock wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: a36d12b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 69.74% (-0.008%) from 69.748% — Anshumancanrock:feat/nip98-redis-nx into cameri:main |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds
ICacheAdapter.setKeyIfNotExists()/ RedisSET … NX(optionalEX) so callers can claim a key once; used next for one-time NIP-98 auth event ids.truewhen the key is created,falsewhen it already exists (nullfrom Redis)setKeyexpiry optionsRelated Issue
Prerequisite for NIP-98 admin API auth (follows #722 verifier; pairs with absolute URL helper). Next: admin middleware.
Motivation and Context
Replay protection needs an atomic “set if absent” primitive. Exposing it on the cache adapter keeps the later middleware thin and reusable.