Skip to content

Major refactor to make testing easier#1

Open
camdroid wants to merge 1 commit into
mainfrom
refactor_and_add_tests
Open

Major refactor to make testing easier#1
camdroid wants to merge 1 commit into
mainfrom
refactor_and_add_tests

Conversation

@camdroid

@camdroid camdroid commented Jul 7, 2025

Copy link
Copy Markdown
Owner

This refactors a lot of the code in the existing dailyClassReminder.py script to make it more readable and easier to add tests. Mostly, I've deleted unused code and simplified data structures where possible (e.g. where some parts of the data are never referenced).

This is a pretty major refactor, so I wouldn't expect to port this in all in one PR. I wanted to put something together to show how a refactor could make the code more readable and easier to work with - that said, there are a ton of edge cases and weird behaviors that I'm not familiar with, so I want to make sure that we take it step-by-step to make changes and reduce the risk of these scripts breaking.

This refactors a lot of the code in the existing dailyClassReminder.py
script to make it more readable and easier to add tests. Mostly, I've
deleted unused code and simplified data structures where possible (e.g.
where some parts of the data are never referenced).

This is a pretty major refactor, so I wouldn't expect to port this in
all in one PR. I wanted to put something together to show how a refactor
could make the code more readable and easier to work with - that said,
there are a ton of edge cases and weird behaviors that I'm not familiar
with, so I want to make sure that we take it step-by-step to make
changes and reduce the risk of these scripts breaking.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant