Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds repository-wide Git hooks via Lefthook (pre-commit and commit-msg) and introduces a Commitlint configuration for conventional commit enforcement, while also updating React Native codegen type imports to align with the current TypeScript declaration paths.
Changes:
- Add Lefthook installation and a
lint:fixscript, and configure hooks to auto-fix staged files and run typechecks pre-commit. - Add Commitlint configuration to enforce conventional commit messages on commit-msg.
- Update React Native internal codegen type imports from
CodegenTypestoCodegenTypesNamespaceto restore typecheck compatibility.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/mlc/src/NativeMLCEngine.ts | Updates RN codegen type import path to CodegenTypesNamespace. |
| packages/apple-llm/src/NativeAppleSpeech.ts | Updates RN codegen type import path to CodegenTypesNamespace. |
| packages/apple-llm/src/NativeAppleLLM.ts | Updates RN codegen type import path to CodegenTypesNamespace. |
| packages/adk/src/NativeAdkEngine.ts | Updates RN codegen type import path to CodegenTypesNamespace. |
| package.json | Adds Lefthook install on prepare and introduces lint:fix; adds Lefthook devDependency. |
| lefthook.yml | Defines pre-commit (eslint --fix + typecheck) and commit-msg (commitlint) hooks. |
| commitlint.config.js | Adds conventional Commitlint configuration. |
| bun.lock | Locks Lefthook dependency resolution. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
grabbou
approved these changes
Jul 6, 2026
grabbou
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me. The type import fix is consistent, CI is green, and the lefthook config validates.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
CodegenTypes.jsfrom Flow, is:CodegenTypesNamespace.d.ts- proper type declarations), which has been addressed