Skip to content

fix(fab): forward long press props so Tooltip works on FAB - #5172

Open
lukewalczak wants to merge 1 commit into
mainfrom
fix/fab-tooltip-press-props
Open

fix(fab): forward long press props so Tooltip works on FAB#5172
lukewalczak wants to merge 1 commit into
mainfrom
fix/fab-tooltip-press-props

Conversation

@lukewalczak

@lukewalczak lukewalczak commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Motivation

Tooltip wrapping a FAB never shows on mobile. Tooltip clones its child with onLongPress, onPressOut and delayLongPress, but since the MD3 FAB rewrite (2f5e55d) FAB and FAB.Extended no longer accept or forward them, so the long press never reaches Tooltip.

 <FAB> / <FAB.Extended>
+  onLongPress, onPressOut, delayLongPress
   <Shell>
+    onLongPress, onPressOut, delayLongPress
     <TouchableRipple onPress … />

Related issue

No issue. Reproducible in the example app's Tooltip screen (FAB in the bottom-right corner).

Screenshots / Videos

Android, long-pressing the FAB in TooltipExample:

Before After
no tooltip image

Test plan

  1. Open the Tooltip example on Android or iOS.
  2. Long-press the FAB in the bottom-right corner and check that the "Press Me" tooltip appears and hides after release.

@github-actions

github-actions Bot commented Nov 5, 2026 •
edited
Loading

Copy link
Copy Markdown

Found potential problems with the pull request:

  • The description is too long. Please keep it under 1000 characters.

@lukewalczak lukewalczak added the FAB label Nov 5, 2026
@lukewalczak
lukewalczak force-pushed the fix/fab-tooltip-press-props branch from cab49a1 to e47e166 Compare November 6, 2026 10:36

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@lukewalczak lukewalczak

Labels

Contributor: Internal FAB

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@lukewalczak