Repository navigation
chore(deps)!: upgrade to React Native 0.88 and Expo SDK 58 - #5167
Conversation
|
I swapped #4996's place with this PR in the merge order which is essentially what D1 asks for in #5150. A few things before review:
|
Thanks for the review!
|
There was a problem hiding this comment.
Overall it looks really solid, great job! I se only 1 blocker (TS stops catching style issues). The rest of the stuff are not really introduced by this PR, they are older but it's a great opportunity to scoop them up now that your diff has touched them.
For the squash commit, could you write the one-line BREAKING CHANGE: footer? Our changelog tool ignores the ! in the title, so it only picks up the break from that line.
- keep SurfaceStyle keys by omitting per AnimatedStyle union member - type Banner, Snackbar and Button touchable refs as React.Ref - document Card.Cover image style props in the migration guide - drop root react-native-web and point docs aliases at its cjs paths
Motivation
Upgrades the example app to Expo SDK 58 / React Native 0.88.1 and migrates
src/to the RN 0.88 types. Refs now useReact.ComponentRef<typeof View>, so the public ref types change.Related issue
Closes #5166
Screenshots / Videos
Test plan
Run
yarn example iosandyarn example android, then open a few examples.