fix(bgp): don't force the plugin's AGP version onto apps - #475
Open
KisaneNeko wants to merge 4 commits into
Open
KisaneNeko wants to merge 4 commits into
KisaneNeko wants to merge 4 commits into
Conversation
added 2 commits
September 28, 2026 15:05
The plugin declared AGP as an `implementation` dependency, so it ended up on the app's buildscript classpath and won version resolution. Since callstack#448 bumped it to AGP 9.2.1, every consumer gets AGP 9.2.1 and its minimum Gradle 9.4.1, which breaks Expo SDK 57 apps (Gradle 9.3.1): "Minimum supported Gradle version is 9.4.1. Current version is 9.3.1." Compile against AGP but let the app provide it at runtime. Also drop the leftover version matrix from the Expo 57 Android build job, which ran the same Expo 57 build twice.
GradleRunner.withPluginClasspath() is built from the runtime classpath, which no longer has AGP now that it is compileOnly, so LegacyConsumerConfigurationTest could not apply com.android.library.
KisaneNeko
marked this pull request as ready for review
September 28, 2026 13:40
hurali97
approved these changes
Sep 29, 2026
added 2 commits
September 29, 2026 13:38
callstack#467 renamed the Expo 56 app and AppleApp's jest.config.expo56.cjs to expo58, but not AndroidApp's, so .detoxrc.expo58.cjs points at a file that doesn't exist and Detox E2E (AndroidApp - Expo 58) fails with "Can't find a root directory while resolving a config file path".
With AGP compileOnly the app provides AGP at runtime, but a plugin built against AGP 9.2.1 references AGP 9 only classes and fails on AGP 8 apps: Expo 57 (AGP 8.12) failed with NoClassDefFoundError com/android/build/api/dsl/AndroidLibrarySourceSet. Built against 8.5.2 (the version before callstack#448) it applies on both AGP 8.12.0 and 9.2.1.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for the Expo 57 Android build failing on main after #448.
The Gradle plugin declared AGP as
implementation, so it ended up on the app's classpath and forced AGP 9.2.1 onto every app using it. That needs Gradle 9.4.1, and Expo 57 apps ship 9.3.1. Changes:compileOnly, so the app's own AGP is usedNoClassDefFoundError. Tested locally: built against 8.5.2 it works on both AGP 8.12.0 and 9.2.1Also fixes two things from #467 that this PR's CI ran into:
apps/AndroidApp/e2e/jest.config.expo56.cjstoexpo58, which the rename missed (Expo 58 Android E2E couldn't find its config)