ci: open an issue when the Expo preview road test fails - #471
Open
KisaneNeko wants to merge 2 commits into
Open
KisaneNeko wants to merge 2 commits into
KisaneNeko wants to merge 2 commits into
Conversation
KisaneNeko
marked this pull request as ready for review
September 24, 2026 09:12
Contributor
Author
|
@hurali97 the AndroidApp - Vanilla E2E tests failed but this seems like a flaky test that happens in other PRs occasionally as well. Re-run should help. Since I added diagnostics to the android there's a screenshot that shows button was there as expected. Logcat shows tests failed because app lost focus and couldn't press it. I wasn't able to figure out what exactly stole focus because logcat is truncated at the end, but after this PR lands we'll have the full trace and I'll see if I can fix it. |
added 2 commits
September 28, 2026 14:13
The job's `if` had no status function, so GitHub prepended `success() &&` and skipped it whenever android or ios failed, which is the only case it is meant to run in. Add `!cancelled()` so it runs on failure but not on a manually cancelled run.
The job has no checkout, so `gh issue list/create` failed with "not a git repository" before reaching the API. Point gh at the workflow's repository.
KisaneNeko
force-pushed
the
fix/expo-preview-road-test
branch
from
September 28, 2026 12:13
1cc6dd3 to
bf2ac7d
Compare
KisaneNeko
changed the title
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #464. The Android road-test fixes for SDK 58 landed in #467, so this PR is now just the fix for the failure-issue job:
ifhad no status check, so GitHub silently addedsuccess() &&and skipped the job whenever a road test failed. Added!cancelled().ghcouldn't tell which repo to use. SetGH_REPO.🤖 Generated with Claude Code