Skip to content

refactor(daemon): move session observability behind facade - #2216

Merged
thymikee merged 1 commit into
mainfrom
refactor/daemon-session-observability-2176
Sep 1, 2026
Merged

refactor(daemon): move session observability behind facade#2216
thymikee merged 1 commit into
mainfrom
refactor/daemon-session-observability-2176

Conversation

@thymikee

@thymikee thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member

Summary

Move the perf, logs, events, network, and audio session routes behind the named observability facade while retaining SessionStore-owned live state, existing admission/resource owners, and exact response behavior.

Closes #2176

Validation

  • Evidence head: 1b92b012574e2f420be12802cca7458bfd489098.
  • Focused observability/resource suites: 12 files, 107 tests passed.
  • pnpm check:layering: 183 tests passed; full guard clean.
  • pnpm check:fallow --base origin/main: no issues in 37 changed files.
  • pnpm check:affected --run: format, lint, typecheck, layering, DI, Fallow, metadata, build, package, Node integration, and macOS coverage lanes passed. The related-test phase had 6 host-load failures with 2,248/2,254 tests passing. The mutation-model self-test independently reproduces 3 current-main registry failures; the clean-main comparison reproduces the 4 iOS/interaction timeout failures.
  • Move-adjusted production size: 119,268 → 119,267 lines (-1).

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown

Size Report

Metric Base Current Diff
JS raw 2.55 MB 2.55 MB -138 B
JS gzip 857.4 kB 857.3 kB -139 B
npm tarball 981.9 kB 981.8 kB -85 B
npm unpacked 3.39 MB 3.39 MB -138 B

npm unpacked components

Component Base Current Diff
JS / dist source 2.71 MB 2.71 MB -138 B
Apple runner source/project 581.2 kB 581.2 kB 0 B
macOS helper source 54.8 kB 54.8 kB 0 B
Android helper artifacts 0 B 0 B 0 B
Other package files 45.7 kB 45.7 kB 0 B

Startup median (7 runs, lower is better):

Scenario Base Current Diff
CLI --version 30.0 ms 30.4 ms +0.4 ms
CLI --help 79.1 ms 80.4 ms +1.3 ms

Top changed chunks:

Chunk Raw diff Gzip diff
dist/src/session-store.js +153 B +47 B
dist/src/session2.js -36 B -11 B

Top changed packed files

Packed file Base Current Diff
dist/src/handler-utils.js 186 B 0 B -186 B
dist/src/session-store.js 40.6 kB 40.7 kB +153 B
dist/src/record-trace.js 1.8 kB 1.8 kB -42 B
dist/src/session2.js 217.7 kB 217.7 kB -36 B
dist/src/find.js 7.2 kB 7.2 kB -27 B

@thymikee

thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

Reviewed exact head 1b92b012574e2f420be12802cca7458bfd489098: no code or architecture findings. The facade is a real ownership boundary, not forwarding ceremony: routing imports one narrow capability input, observability owns family dispatch/composition, specialized operations remain private, store-owned state and admission/resource owners are preserved, and anti-regrowth/deep-import gates are meaningful. All exact-head CI is green and move-adjusted production LOC is -1. BLOCKED only on the readiness record: stamp the PR body’s Validation with this exact head so the local/fallow/affected evidence and documented host-load noise are tied to a named commit.

@thymikee

thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

Addressed: added the exact validated head 1b92b01 to the PR Validation section, tying the local, Fallow, and affected evidence to this commit.

@thymikee

thymikee commented Sep 1, 2026

Copy link
Copy Markdown
Member Author

Re-reviewed exact head 1b92b012574e2f420be12802cca7458bfd489098: the sole readiness-record blocker is resolved. Validation now stamps this exact head and ties the focused, layering, Fallow, affected, and host-load comparison evidence to it. Code/architecture remain clean, all exact-head CI and iOS/Android/macOS/Linux Smoke lanes pass, package size is -138 B, and move-adjusted production is -1 LOC. READY for human review and merge.

@thymikee thymikee added the ready-for-human Valid work that needs human implementation, judgment, or maintainer merge label Sep 1, 2026
@thymikee
thymikee merged commit 544a804 into main Sep 1, 2026
18 checks passed
@thymikee
thymikee deleted the refactor/daemon-session-observability-2176 branch September 1, 2026 14:39
@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-09-01 14:39 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-human Valid work that needs human implementation, judgment, or maintainer merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(daemon): move session observability behind one capability facade

1 participant