refactor(snapshot): move text-surface into snapshot presentation - #2152
Open
thymikee wants to merge 1 commit into
Open
refactor(snapshot): move text-surface into snapshot presentation#2152thymikee wants to merge 1 commit into
thymikee wants to merge 1 commit into
Conversation
Size Report
npm unpacked components
Startup median (7 runs, lower is better):
Top changed chunks: no changes in the largest emitted chunks. Top changed packed filesNo changed packed files. |
Member
Author
|
Review found no code or ownership-design issues. This is the intended smallest #2129 child: the byte-identical text-surface policy and its test move into ADR 0004's existing snapshot-presentation owner, the three declared consumers follow it, and no |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move the snapshot text-surface policy and its test from
src/utilsinto the existingsrc/snapshot/snapshot-presentationowner.Update the three production importers and move the path-keyed Fallow baseline entry. The production module is byte-identical and no runtime behavior changes.
Closes #2133
Validation
pnpm vitest run src/snapshot/snapshot-presentation/text-surface.test.tspnpm vitest run src/commands/interaction/runtime/selector-read.test.ts src/daemon/handlers/__tests__/interaction-read.test.tsnode --experimental-strip-types --test scripts/layering/snapshot-presentation-boundary.test.tspnpm formatpnpm check:affected --run— all runnable checks passed; native, device, coverage, and other GitHub-authoritative lanes remain for CI.