Skip to content

skycoord obstime and equinox support#27

Open
calgray wants to merge 4 commits into
mainfrom
obstime
Open

skycoord obstime and equinox support#27
calgray wants to merge 4 commits into
mainfrom
obstime

Conversation

@calgray

@calgray calgray commented Jun 17, 2026

Copy link
Copy Markdown
Owner

When using differentials with SkyCoords, obstime is an important data property for the calculating the coordinate at other epochs such as when using apply_space_motion(new_obstime=new_time). For frames that don't support obstime, SkyCoord has a transitive optional obstime constructor argument.

There is likewise also an optional equinox argument for SkyCoord that's not as useful, but can also be supported for completeness.

  • Closes #xxxx
  • Tests added
  • Passes pre-commit run --all-files
  • User visible changes (including notable bug fixes) are documented in whats-new.rst
  • New functions/methods are listed in api.rst

Signed-off-by: Callan Gray <cal.j.gray@gmail.com>
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.12%. Comparing base (ab9964b) to head (7c14ecb).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #27      +/-   ##
==========================================
+ Coverage   85.93%   86.12%   +0.18%     
==========================================
  Files          14       14              
  Lines        1152     1153       +1     
  Branches      179      178       -1     
==========================================
+ Hits          990      993       +3     
+ Misses        115      114       -1     
+ Partials       47       46       -1     
Flag Coverage Δ
unittests 86.03% <100.00%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
astropy_xarray/coordinates/frame.py 90.43% <100.00%> (+1.54%) ⬆️
astropy_xarray/coordinates/sky_coord.py 97.91% <100.00%> (+0.13%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Callan Gray <cal.j.gray@gmail.com>
@calgray calgray changed the title skycoord obstime support skycoord obstime and equinox support Jun 17, 2026
calgray added 2 commits June 18, 2026 00:08
Signed-off-by: Callan Gray <cal.j.gray@gmail.com>
Signed-off-by: Callan Gray <cal.j.gray@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants