feat: wire DAWN_E codes into dawn verify + enforce gpt-5 example ids in docs#359
Open
blove wants to merge 2 commits into
Open
feat: wire DAWN_E codes into dawn verify + enforce gpt-5 example ids in docs#359blove wants to merge 2 commits into
blove wants to merge 2 commits into
Conversation
Add DAWN_E5101 ("Node version below the supported floor") to the
@dawn-ai/sdk error registry, and surface it (or the existing
DAWN_E2002 for an unreachable sandbox daemon) on a failed `dawn
verify` runtime check. RuntimeCheckResult.node/docker carry an
optional `code` field, and the CliError thrown on a failed verify
gains the matching code so text mode prints `[DAWN_E5101] See ...`
and --json mode exposes it on the runtime check.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Add a narrow check-docs.mjs rule flagging an OpenAI legacy model id (gpt-4*, gpt-3*, o1*) used as an example `model:` value anywhere under apps/web/content/docs, excluding api.mdx (the model-id reference page, which intentionally lists legacy ids across every provider). Non-OpenAI provider ids (llama, claude, gemini, ...) are never flagged. Confirmed the rule passes against current docs and fails when a violation is injected. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small post-registry tidy-ups (both surfaced during the DX-follow-up trio).
1. Wire error codes into
dawn verify(was blocked on the registry #357)DAWN_E5101("Node version below the supported floor") to the@dawn-ai/sdkregistry (E5xxx runtime range; nodocsPath— no page anchors the Node floor, matchingDAWN_E5001).errors.mdx+ the drift guard regenerated.dawn verify's runtime check now surfaces codes:checks[].node.code = DAWN_E5101on a stale Node,checks[].docker.code = DAWN_E2002on an unreachable daemon (both conditional-spread, failure-only). Text mode prints[DAWN_E5101] See https://dawnai.org/…via the existing CliError path;--jsonexposes them directly. TheTODO(error-codes)markers left by feat(cli): dawn verify runs an environment preflight (Node floor, Docker, provider-derived keys) #358 are gone.2. Enforce gpt-5-family OpenAI example ids in docs
The "gpt-5 family in examples" convention was assumed-enforced but wasn't (found while writing AGENTS.md). Added a narrow, safe
check-docs.mjsrule: flags an OpenAI legacy id used as an examplemodel:value (gpt-4…/gpt-3…/o1…), excluding theapi.mdxmodel-id reference page and leaving non-OpenAI provider ids (e.g. thellama3.1ollama example) untouched.model: "gpt-4o"fails with a clear message, reverted).Changeset: patch
@dawn-ai/sdk+@dawn-ai/cli(#2 is script-only). Full local verify green (build 23/23 · typecheck 24/24 · lint · 1193 tests · check-docs · pack-check).🤖 Generated with Claude Code